[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6728: upgrade a backported patch

[GitBox <gi...@apache.org>]

DaanHoogland commented on code in PR #6728:
URL: https://github.com/apache/cloudstack/pull/6728#discussion_r968231274


##########
engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql:
##########
@@ -887,9 +887,8 @@ left join `cloud`.`mshost_status` on
     ((`cloud`.`mshost`.`uuid` = `cloud`.`mshost_status`.`ms_id`)));
 
 -- Alter event table to add resource_id and resource_type
-ALTER TABLE `cloud`.`event`
-    ADD COLUMN `resource_id` bigint unsigned COMMENT 'ID of the resource associated with the event' AFTER `domain_id`,
-    ADD COLUMN `resource_type` varchar(32) COMMENT 'Type of the resource associated with the event' AFTER `resource_id`;
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.event','resource_id', 'bigint unsigned COMMENT "ID of the resource associated with the event" AFTER `domain_id`');

Review Comment:
   sure, but also it should already be present in the server. We have re-defined it in several upgrade steps.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org