You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by yukon <yu...@apache.org> on 2017/04/14 02:24:08 UTC

Re: [DISCUSS] Import Maintain...

Hi Bruce,

> Is the RocketMQ code base currently divided up with certain people
working only in certain areas?

Not only, but most of committers have their focus areas.

We don't want to divide the code base totally for certain people, IMO,
global collaboration with a certain focus may be a better efficient way.

Regards,

yukon





On Thu, Apr 13, 2017 at 10:09 PM, Bruce Snyder <br...@gmail.com>
wrote:

> Hi yukon,
>
> I haven't heard of this concept at the ASF before, so I guess it's
> something that only a few projects are using. It seems kinda heavy-handed,
> but maybe this is just my perspective in not having worked on the RocketMQ
> code base. Is the RocketMQ code base currently divided up with certain
> people working only in certain areas?
>
> Bruce
>
> On Thu, Apr 13, 2017 at 2:12 AM, yukon <yu...@apache.org> wrote:
>
> > Hi all,
> >
> > We have noticed that there are some problems in our PR review process, as
> > Justin mentioned in the IPMC board report, the slow PR processing speed
> > will drain contributors' positive energy for continuous contribution,
> which
> > will impede healthy development of Apache RocketMQ community.
> >
> > So we want to import the maintainer mechanism for Apache RocketMQ to
> > promote the development of community efficiently, but I am not sure
> whether
> > it's ok for a incubator project, please mentors let me know If there are
> > any problems.
> >
> > Since there are many Apache projects have maintainers[1][2], with some
> > major responsibilities for the code base, and we want to try out this
> > mechanism for a certain time. Each major component has 2~3 maintainers,
> who
> > are responsible for the following:
> >
> > 1. Providing timely feedback on JIRA issues, bug reports, wishes, and so
> > on.
> > 2. Review code contributions(PRs) as promptly as possible, also
> coordinate
> > other committers to help review.
> > 3. Merge PRs after review stage.
> >
> > Any advice is welcome.
> >
> > [1]. http://mesos.apache.org/documentation/latest/committers/
> > [2]. https://cwiki.apache.org/confluence/display/KAFKA/Maintainers
> >
> > Regards,
> > yukon
> >
>
>
>
> --
> perl -e 'print
> unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*" );'
>
> ActiveMQ in Action: http://bit.ly/2je6cQ
> Blog: http://bsnyder.org/ <http://bruceblog.org/>
> Twitter: http://twitter.com/brucesnyder
>

Re: [DISCUSS] Import Maintain...

Posted by Luke Han <lu...@gmail.com>.
Apache community and project is different than other open source project,
there's no "maintainer" role.

Please refer to this doc very clear and follow The Apache Way:
https://www.apache.org/foundation/how-it-works.html#roles

If someone contributed much and worth to invite to be committer,
please do that and do not limit to be any other role which not introduced
by ASF.

Thanks.
Luke



Best Regards!
---------------------

Luke Han

On Fri, Apr 14, 2017 at 11:27 AM, Harsha <ro...@harsha.io> wrote:

> Hi,
>       If the goal is to move the project more quickly, adding
>       maintainers will only hinder the progress not help move faster as
>       it's another layer of getting a patch committed. Since RocketMQ is
>       still in the incubation stage, IMO too soon to introduce
>       maintainers. Once the project matures into a bigger community,
>       maintainers might help.
>       Since the goal is to move the project quicker I think the goal
>       should provide guidance in promoting the current contributors to
>       committers so that they can help handle the PR volume.
>
> Thanks,
> Harsha
>
> On Thu, Apr 13, 2017, at 07:24 PM, yukon wrote:
> > Hi Bruce,
> >
> > > Is the RocketMQ code base currently divided up with certain people
> > working only in certain areas?
> >
> > Not only, but most of committers have their focus areas.
> >
> > We don't want to divide the code base totally for certain people, IMO,
> > global collaboration with a certain focus may be a better efficient way.
> >
> > Regards,
> >
> > yukon
> >
> >
> >
> >
> >
> > On Thu, Apr 13, 2017 at 10:09 PM, Bruce Snyder <br...@gmail.com>
> > wrote:
> >
> > > Hi yukon,
> > >
> > > I haven't heard of this concept at the ASF before, so I guess it's
> > > something that only a few projects are using. It seems kinda
> heavy-handed,
> > > but maybe this is just my perspective in not having worked on the
> RocketMQ
> > > code base. Is the RocketMQ code base currently divided up with certain
> > > people working only in certain areas?
> > >
> > > Bruce
> > >
> > > On Thu, Apr 13, 2017 at 2:12 AM, yukon <yu...@apache.org> wrote:
> > >
> > > > Hi all,
> > > >
> > > > We have noticed that there are some problems in our PR review
> process, as
> > > > Justin mentioned in the IPMC board report, the slow PR processing
> speed
> > > > will drain contributors' positive energy for continuous contribution,
> > > which
> > > > will impede healthy development of Apache RocketMQ community.
> > > >
> > > > So we want to import the maintainer mechanism for Apache RocketMQ to
> > > > promote the development of community efficiently, but I am not sure
> > > whether
> > > > it's ok for a incubator project, please mentors let me know If there
> are
> > > > any problems.
> > > >
> > > > Since there are many Apache projects have maintainers[1][2], with
> some
> > > > major responsibilities for the code base, and we want to try out this
> > > > mechanism for a certain time. Each major component has 2~3
> maintainers,
> > > who
> > > > are responsible for the following:
> > > >
> > > > 1. Providing timely feedback on JIRA issues, bug reports, wishes,
> and so
> > > > on.
> > > > 2. Review code contributions(PRs) as promptly as possible, also
> > > coordinate
> > > > other committers to help review.
> > > > 3. Merge PRs after review stage.
> > > >
> > > > Any advice is welcome.
> > > >
> > > > [1]. http://mesos.apache.org/documentation/latest/committers/
> > > > [2]. https://cwiki.apache.org/confluence/display/KAFKA/Maintainers
> > > >
> > > > Regards,
> > > > yukon
> > > >
> > >
> > >
> > >
> > > --
> > > perl -e 'print
> > > unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*"
> );'
> > >
> > > ActiveMQ in Action: http://bit.ly/2je6cQ
> > > Blog: http://bsnyder.org/ <http://bruceblog.org/>
> > > Twitter: http://twitter.com/brucesnyder
> > >
>

Re: [DISCUSS] Import Maintain...

Posted by Harsha <ro...@harsha.io>.
Hi,
      If the goal is to move the project more quickly, adding
      maintainers will only hinder the progress not help move faster as
      it's another layer of getting a patch committed. Since RocketMQ is
      still in the incubation stage, IMO too soon to introduce
      maintainers. Once the project matures into a bigger community,
      maintainers might help.
      Since the goal is to move the project quicker I think the goal
      should provide guidance in promoting the current contributors to
      committers so that they can help handle the PR volume.

Thanks,
Harsha

On Thu, Apr 13, 2017, at 07:24 PM, yukon wrote:
> Hi Bruce,
> 
> > Is the RocketMQ code base currently divided up with certain people
> working only in certain areas?
> 
> Not only, but most of committers have their focus areas.
> 
> We don't want to divide the code base totally for certain people, IMO,
> global collaboration with a certain focus may be a better efficient way.
> 
> Regards,
> 
> yukon
> 
> 
> 
> 
> 
> On Thu, Apr 13, 2017 at 10:09 PM, Bruce Snyder <br...@gmail.com>
> wrote:
> 
> > Hi yukon,
> >
> > I haven't heard of this concept at the ASF before, so I guess it's
> > something that only a few projects are using. It seems kinda heavy-handed,
> > but maybe this is just my perspective in not having worked on the RocketMQ
> > code base. Is the RocketMQ code base currently divided up with certain
> > people working only in certain areas?
> >
> > Bruce
> >
> > On Thu, Apr 13, 2017 at 2:12 AM, yukon <yu...@apache.org> wrote:
> >
> > > Hi all,
> > >
> > > We have noticed that there are some problems in our PR review process, as
> > > Justin mentioned in the IPMC board report, the slow PR processing speed
> > > will drain contributors' positive energy for continuous contribution,
> > which
> > > will impede healthy development of Apache RocketMQ community.
> > >
> > > So we want to import the maintainer mechanism for Apache RocketMQ to
> > > promote the development of community efficiently, but I am not sure
> > whether
> > > it's ok for a incubator project, please mentors let me know If there are
> > > any problems.
> > >
> > > Since there are many Apache projects have maintainers[1][2], with some
> > > major responsibilities for the code base, and we want to try out this
> > > mechanism for a certain time. Each major component has 2~3 maintainers,
> > who
> > > are responsible for the following:
> > >
> > > 1. Providing timely feedback on JIRA issues, bug reports, wishes, and so
> > > on.
> > > 2. Review code contributions(PRs) as promptly as possible, also
> > coordinate
> > > other committers to help review.
> > > 3. Merge PRs after review stage.
> > >
> > > Any advice is welcome.
> > >
> > > [1]. http://mesos.apache.org/documentation/latest/committers/
> > > [2]. https://cwiki.apache.org/confluence/display/KAFKA/Maintainers
> > >
> > > Regards,
> > > yukon
> > >
> >
> >
> >
> > --
> > perl -e 'print
> > unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*" );'
> >
> > ActiveMQ in Action: http://bit.ly/2je6cQ
> > Blog: http://bsnyder.org/ <http://bruceblog.org/>
> > Twitter: http://twitter.com/brucesnyder
> >