[GitHub] [rocketmq-client-cpp] jonnxu commented on a change in pull request #174: [ISSUE#145] Wrong lock flag for pull request in orderly consume when unlock

[GitBox <gi...@apache.org>]

jonnxu commented on a change in pull request #174: [ISSUE#145] Wrong lock flag for pull request in orderly consume when unlock
URL: https://github.com/apache/rocketmq-client-cpp/pull/174#discussion_r312064155
 
 

 ##########
 File path: src/consumer/Rebalance.cpp
 ##########
 @@ -311,7 +311,7 @@ void Rebalance::unlock(MQMessageQueue mq) {
       PullRequest* pullreq = getPullRequest(mqs[i]);
       if (pullreq) {
         LOG_INFO("unlock success of mq:%s", mqs[i].toString().c_str());
-        pullreq->setLocked(true);
+        pullreq->setLocked(false);
 
 Review comment:
   good

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services