You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/06/14 10:00:00 UTC
[jira] [Work logged] (AMQ-8613) Improve performance of selectors with a big sequence of OR and AND logical expressions
[ https://issues.apache.org/jira/browse/AMQ-8613?focusedWorklogId=781065&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781065 ]
ASF GitHub Bot logged work on AMQ-8613:
---------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/22 09:59
Start Date: 14/Jun/22 09:59
Worklog Time Spent: 10m
Work Description: eolivelli commented on PR #842:
URL: https://github.com/apache/activemq/pull/842#issuecomment-1154976307
@jbonofre I have a couple of additional enhancements.
I have some numbers on our applications (with this PR + the follow up patches, all stacked), we are saving some good amount of CPU cycles and we decided to commit these changes in our repo.
@dave2wave has some numbers, but I am not sure they are meaningful here.
Issue Time Tracking
-------------------
Worklog Id: (was: 781065)
Time Spent: 40m (was: 0.5h)
> Improve performance of selectors with a big sequence of OR and AND logical expressions
> --------------------------------------------------------------------------------------
>
> Key: AMQ-8613
> URL: https://issues.apache.org/jira/browse/AMQ-8613
> Project: ActiveMQ
> Issue Type: Improvement
> Components: JMS client
> Affects Versions: 5.17.1
> Reporter: Enrico Olivelli
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently when you create a selector with OR and ANDs the filter creates a huge stack trace.
> This is because for each element in the OR and AND expression node we have to execute a method call.
> This is happening because OR and AND expressions are treated as BinaryExpressions.
> A very simple but effecting improvement is to not represent OR and AND expressions as binary expression but store the list of siblings expression in only one node.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)