You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by Stian Soiland-Reyes <st...@apache.org> on 2016/06/01 11:01:11 UTC
[VOTE] Release Apache Taverna Command-line Tool 3.1.0-incubating RC2
I am pleased to be calling this vote for the source release of
Apache Taverna Engine 3.1.0-incubating
Apache Taverna Common Activities 2.1.0-incubating
Apache Taverna Command-line Tool 3.1.0-incubating
This is the second release candidate, fixing TAVERNA-975 and TAVERNA-973.
If you tested RC1 earlier, make sure you delete the folder
~/.m2/repository/org/apache/taverna/ before building this release candidate.
To discuss this release candidate, use the corresponding [DISCUSS] thread.
Apache Taverna Engine executes Taverna workflows, defined using
Apache Taverna Language or Taverna 2's .t2flow format, and
provides OSGi services for monitoring and controlling the
detailed execution of workflow.
Apache Taverna Common Activities provide bindings for the
Taverna Engine to invoke activities such as
command line tools (local/ssh), Beanshell scripts,
REST and WSDL services, spreadsheet import and
user interactions.
Apache Taverna Command-line Tool provides a shell command
for executing Taverna workflows, with output of results to either
a folder or a Research Object bundle including detailed provenance.
In addition to the Taverna Common Activities, the Command-line
supports plugins using Taverna OSGi services.
The release candidates to be voted over are available at:
https://dist.apache.org/repos/dist/dev/incubator/taverna/source/rc2/ (r13865)
SHA-1 checksums:
cb0176c33391d1c2d17eae973e0d665cc90bbc94
apache-taverna-commandline-3.1.0-incubating-source-release.zip
1c0446734950c7360aa0d1c95952d0acb148a783
apache-taverna-common-activities-2.1.0-incubating-source-release.zip
a021e8b278685d25839b508b8ab727c28916325a
apache-taverna-engine-3.1.0-incubating-source-release.zip
MD5 checksums:
cb0176c33391d1c2d17eae973e0d665cc90bbc94
apache-taverna-commandline-3.1.0-incubating-source-release.zip
1c0446734950c7360aa0d1c95952d0acb148a783
apache-taverna-common-activities-2.1.0-incubating-source-release.zip
a021e8b278685d25839b508b8ab727c28916325a
apache-taverna-engine-3.1.0-incubating-source-release.zip
Build the release candidate *in the above order*, using:
mvn clean install
Tip: On a multi-core machine with a fast disk you can speed up the
build by turning off anti-virus real-time protection and adding the
mvn parameter -T1C
The release candidates correspond to the following git commits:
https://git-wip-us.apache.org/repos/asf?p=incubator-taverna-engine.git;a=commit;h=690f751c0e7a0173322e01265358f75d33b14525
https://git-wip-us.apache.org/repos/asf?p=incubator-taverna-common-activities.git;a=commit;h=faa8927eff68a50a2b200ce17a54bb2234538b4f
https://git-wip-us.apache.org/repos/asf?p=incubator-taverna-commandline.git;a=commit;h=ca496f74e84e6ec2cb2a4e2eddeb655c2d15a20a
Release candidates are signed with a GPG key available at:
https://dist.apache.org/repos/dist/release/incubator/taverna/KEYS
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachetaverna-1014/
The changelog for this release is available from JIRA:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318322&version=12332249
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318322&version=12332250
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318322&version=12335847
Please vote on releasing these packages as:
Apache Taverna Engine 3.1.0-incubating
Apache Taverna Common Activities 2.1.0-incubating
Apache Taverna Command-line Tool 3.1.0-incubating
The vote is open for at least 72 hours and passes if a
majority of at least three +1 Apache Taverna PPMC votes are cast.
[ ] +1 Release this package
[ ] 0 I don't feel strongly about it, but don't object
[ ] -1 Do not release this package because...
Anyone can participate in testing and voting, not just
committers, please feel free to try out the release candidate
and provide your votes.
How to review a release candidate? https://s.apache.org/review-release
--
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons
http://orcid.org/0000-0001-9842-9718
Re: [VOTE] Release Apache Taverna Command-line Tool 3.1.0-incubating RC2
Posted by Gale Naylor <Ga...@noventussolutions.com>.
There is no #3. I just forgot to adjust the numbers.
On Thu, Jun 2, 2016 at 10:56 AM Gale Naylor <Ga...@noventussolutions.com>
wrote:
> I finished reviewing all the file headers. Here is what I found:
>
> -------------------
> Non-ASF Copyrights
> -------------------
>
> 1) University of Manchester copyright in taverna-provenanceconnector
> files (see previous email).
>
> 2) taverna-execution-hadoop Crossproduct.java file contains copyright
> by Adam Pingel and no ASF license.
>
> I know this is copyright is included in the top level NOTICE
> file, but doesn't it have to be removed from the Java file?
>
> -------------------
> Missing ASF licenses?
> -------------------
>
> 1) Two README files without license headers:
>
> /taverna-engine-rc2/taverna-prov/README.md
> /taverna-engine-rc2/taverna-reference-types/README.md
>
>
> 2) One JSON file without license header
>
> /taverna-engine-rc2/taverna-run-impl/src/test/resources/workflowrun.json
>
>
> 4) Miscellaneous text and html files don't have a license header.
> (Also spring.handlers and spring.schemas.)
> Are these not considered "code?"
>
> Examples:
> taverna-activity-archetype...goal.txt,
> taverna-credential-manager...text.html,
> taverna-prov...3a/3a82e39d-a537-40cf-91a0-2c89d4a2e62b.txt
> taverna-prov...greeting.txt
> taverna-prov...mimetype
> taverna-workflowmodel-impl...package.html
> taverna-reference-impl...spring.handlers (and spring.schemas)
>
>
> 5) Files in services subdirectories also do not have a license headers.
> Are they exempt?
>
> Examples:
> taverna-credential-manager...services/
> org.apache.taverna.security.credentialmanager.CredentialProviderSPI
> taverna-dataflow-activity.../services/
> net.sf.taverna.t2.workflowmodel.health.HealthChecker
>
>
> Well. That was mind-numbing. Whew! Glad I'm done with that part.
>
> Gale
>
> On Thu, Jun 2, 2016 at 9:30 AM Alan Williams <al...@googlemail.com>
> wrote:
>
>> On 02-Jun-16 17:01, Gale Naylor wrote:
>> > Hello,
>> >
>> > I am finding University of Manchester copyright notices on many of the
>> > files in taverna-provenanceconnector. This is not allowed, right? (
>> > http://www.apache.org/legal/src-headers.html#headers)
>> >
>> > For example:
>> > src/main/java/org/apache/taverna/provenance/api/ProvenanceAccess.java
>> >
>> > and all the java files in
>> > /src/main/java/org/apache/taverna/provenance/lineageservice/types/
>>
>> I can confirm that the files have the old Manchester license at the top
>> with the Apache license later on. Github found several
>>
>> https://github.com/apache/incubator-taverna-engine/search?utf8=%E2%9C%93&q=University+of+Manchester
>>
>> I checked the common activities and commandline and they seem OK.
>>
>> > Gale
>>
>> Alan
>>
>
Re: [VOTE] Release Apache Taverna Command-line Tool 3.1.0-incubating RC2
Posted by Gale Naylor <Ga...@noventussolutions.com>.
I finished reviewing all the file headers. Here is what I found:
-------------------
Non-ASF Copyrights
-------------------
1) University of Manchester copyright in taverna-provenanceconnector
files (see previous email).
2) taverna-execution-hadoop Crossproduct.java file contains copyright
by Adam Pingel and no ASF license.
I know this is copyright is included in the top level NOTICE
file, but doesn't it have to be removed from the Java file?
-------------------
Missing ASF licenses?
-------------------
1) Two README files without license headers:
/taverna-engine-rc2/taverna-prov/README.md
/taverna-engine-rc2/taverna-reference-types/README.md
2) One JSON file without license header
/taverna-engine-rc2/taverna-run-impl/src/test/resources/workflowrun.json
4) Miscellaneous text and html files don't have a license header.
(Also spring.handlers and spring.schemas.)
Are these not considered "code?"
Examples:
taverna-activity-archetype...goal.txt,
taverna-credential-manager...text.html,
taverna-prov...3a/3a82e39d-a537-40cf-91a0-2c89d4a2e62b.txt
taverna-prov...greeting.txt
taverna-prov...mimetype
taverna-workflowmodel-impl...package.html
taverna-reference-impl...spring.handlers (and spring.schemas)
5) Files in services subdirectories also do not have a license headers. Are
they exempt?
Examples:
taverna-credential-manager...services/
org.apache.taverna.security.credentialmanager.CredentialProviderSPI
taverna-dataflow-activity.../services/
net.sf.taverna.t2.workflowmodel.health.HealthChecker
Well. That was mind-numbing. Whew! Glad I'm done with that part.
Gale
On Thu, Jun 2, 2016 at 9:30 AM Alan Williams <al...@googlemail.com>
wrote:
> On 02-Jun-16 17:01, Gale Naylor wrote:
> > Hello,
> >
> > I am finding University of Manchester copyright notices on many of the
> > files in taverna-provenanceconnector. This is not allowed, right? (
> > http://www.apache.org/legal/src-headers.html#headers)
> >
> > For example:
> > src/main/java/org/apache/taverna/provenance/api/ProvenanceAccess.java
> >
> > and all the java files in
> > /src/main/java/org/apache/taverna/provenance/lineageservice/types/
>
> I can confirm that the files have the old Manchester license at the top
> with the Apache license later on. Github found several
>
> https://github.com/apache/incubator-taverna-engine/search?utf8=%E2%9C%93&q=University+of+Manchester
>
> I checked the common activities and commandline and they seem OK.
>
> > Gale
>
> Alan
>
Re: [VOTE] Release Apache Taverna Command-line Tool 3.1.0-incubating RC2
Posted by Stian Soiland-Reyes <st...@apache.org>.
Yes, this is a clear -1, so I'm cancelling this RC.
I think these snuck past the apache-rat check as they contains BOTH
ASF and LGPL headers.
Thanks for checking, Alan!
On 2 June 2016 at 17:29, Alan Williams <al...@googlemail.com> wrote:
> On 02-Jun-16 17:01, Gale Naylor wrote:
>>
>> Hello,
>>
>> I am finding University of Manchester copyright notices on many of the
>> files in taverna-provenanceconnector. This is not allowed, right? (
>> http://www.apache.org/legal/src-headers.html#headers)
>>
>> For example:
>> src/main/java/org/apache/taverna/provenance/api/ProvenanceAccess.java
>>
>> and all the java files in
>> /src/main/java/org/apache/taverna/provenance/lineageservice/types/
>
>
> I can confirm that the files have the old Manchester license at the top with
> the Apache license later on. Github found several
> https://github.com/apache/incubator-taverna-engine/search?utf8=%E2%9C%93&q=University+of+Manchester
>
> I checked the common activities and commandline and they seem OK.
>
>> Gale
>
>
> Alan
--
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons
http://orcid.org/0000-0001-9842-9718
Re: [VOTE] Release Apache Taverna Command-line Tool 3.1.0-incubating
RC2
Posted by Alan Williams <al...@googlemail.com>.
On 02-Jun-16 17:01, Gale Naylor wrote:
> Hello,
>
> I am finding University of Manchester copyright notices on many of the
> files in taverna-provenanceconnector. This is not allowed, right? (
> http://www.apache.org/legal/src-headers.html#headers)
>
> For example:
> src/main/java/org/apache/taverna/provenance/api/ProvenanceAccess.java
>
> and all the java files in
> /src/main/java/org/apache/taverna/provenance/lineageservice/types/
I can confirm that the files have the old Manchester license at the top
with the Apache license later on. Github found several
https://github.com/apache/incubator-taverna-engine/search?utf8=%E2%9C%93&q=University+of+Manchester
I checked the common activities and commandline and they seem OK.
> Gale
Alan
Re: [VOTE] Release Apache Taverna Command-line Tool 3.1.0-incubating RC2
Posted by Gale Naylor <Ga...@noventussolutions.com>.
Hello,
I am finding University of Manchester copyright notices on many of the
files in taverna-provenanceconnector. This is not allowed, right? (
http://www.apache.org/legal/src-headers.html#headers)
For example:
src/main/java/org/apache/taverna/provenance/api/ProvenanceAccess.java
and all the java files in
/src/main/java/org/apache/taverna/provenance/lineageservice/types/
Gale
On Wed, Jun 1, 2016 at 6:16 PM Gale Naylor <Ga...@noventussolutions.com>
wrote:
> Starting the review process...
>
> ------------------------------------------
> UP-FRONT CHECKS
> ------------------------------------------
> The MD5 checksums in the [VOTE] email are the same as the SHA1 checksums.
> I'm using the downloaded MD5 and SHA-1.
>
> (Question) I'm curious what r13865 means:
> https://dist.apache.org/repos/dist/dev/incubator/taverna/source/rc2/
> (r13865)
>
> I didn't see the commit ID in the [VOTE] email. Did I miss it?
>
> ------------------------------------------
> LICENSES - THIRD-PARTY.properties file
> ------------------------------------------
>
> The list of # Already used licenses in project : includes
>
> # - GNU Lesser General Public License, Version 2.1
> Isn't this a category-x license? (It doesn't show up in the
> "Please fill in the missing licenses" list.)
>
>
> Missing licenses:
> # http://x-stream.github.io/license.html - this link says BSD (but not
> which type);
> should this copyright be included in our Notice file?
>
> org.aopalliance--com.springsource.org.aopalliance--1.0.0 - no license
> listed
>
> # https://github.com/hunterhacker/jdom/blob/jdom-1.1/core/LICENSE.txt -
> this link has a copyright;
> include in Notice file? What do we use for "type" of license? "Copyright?"
> Or is this also a "JDOM License" like
> org.jdom--com.springsource.org.jdom--1.1.0?
>
> # http://www.xmlpull.org/ - no license listed
>
> Category B licenses?
> Aren't these listed under category-b, binary release only? Or do they meet
> the exception
> for allowing in a source release? ("For small amounts of source that is
> directly
> consumed by the ASF product at runtime in source form, and for which that
> source is unmodified and unlikely to be changed ...")
>
> javax.transaction--com.springsource.javax.transaction--1.1.0 - CDDL 1.0
>
> org.aspectj--com.springsource.org.aspectj.runtime--1.6.0 - Eclipse Public
> License 1.0
> org.aspectj--com.springsource.org.aspectj.weaver--1.6.0 - Eclipse Public
> License 1.0
>
> That's as far as I can get today. Will do the rest of the review tomorrow.
>
> Gale
>
> On Wed, Jun 1, 2016 at 7:18 AM Stian Soiland-Reyes <st...@apache.org>
> wrote:
>
>> On 1 June 2016 at 12:01, Stian Soiland-Reyes <st...@apache.org> wrote:
>> > I am pleased to be calling this vote for the source release of
>> >
>> > Apache Taverna Engine 3.1.0-incubating
>> > Apache Taverna Common Activities 2.1.0-incubating
>> > Apache Taverna Command-line Tool 3.1.0-incubating
>> > ..
>> > Build the release candidate *in the above order*, using:
>>
>> Sorry I mixed up the order in the checksums which were immediately
>> above in this vote email - to clarify the build order is:
>>
>> taverna-engine
>> taverna-common-activities
>> taverna-commandline
>>
>> The reason is that command line depends on common-activities, which
>> depend on taverna-engine, all in the same version as being released.
>>
>>
>> Perhaps for the next vote emails I will include the full URIs to the
>> folders rather than just ../rc2/
>>
>>
>> --
>> Stian Soiland-Reyes
>> Apache Taverna (incubating), Apache Commons
>> http://orcid.org/0000-0001-9842-9718
>>
>
Re: [VOTE] Release Apache Taverna Command-line Tool 3.1.0-incubating RC2
Posted by Gale Naylor <Ga...@noventussolutions.com>.
Starting the review process...
------------------------------------------
UP-FRONT CHECKS
------------------------------------------
The MD5 checksums in the [VOTE] email are the same as the SHA1 checksums.
I'm using the downloaded MD5 and SHA-1.
(Question) I'm curious what r13865 means:
https://dist.apache.org/repos/dist/dev/incubator/taverna/source/rc2/
(r13865)
I didn't see the commit ID in the [VOTE] email. Did I miss it?
------------------------------------------
LICENSES - THIRD-PARTY.properties file
------------------------------------------
The list of # Already used licenses in project : includes
# - GNU Lesser General Public License, Version 2.1
Isn't this a category-x license? (It doesn't show up in the
"Please fill in the missing licenses" list.)
Missing licenses:
# http://x-stream.github.io/license.html - this link says BSD (but not
which type);
should this copyright be included in our Notice file?
org.aopalliance--com.springsource.org.aopalliance--1.0.0 - no license
listed
# https://github.com/hunterhacker/jdom/blob/jdom-1.1/core/LICENSE.txt -
this link has a copyright;
include in Notice file? What do we use for "type" of license? "Copyright?"
Or is this also a "JDOM License" like
org.jdom--com.springsource.org.jdom--1.1.0?
# http://www.xmlpull.org/ - no license listed
Category B licenses?
Aren't these listed under category-b, binary release only? Or do they meet
the exception
for allowing in a source release? ("For small amounts of source that is
directly
consumed by the ASF product at runtime in source form, and for which that
source is unmodified and unlikely to be changed ...")
javax.transaction--com.springsource.javax.transaction--1.1.0 - CDDL 1.0
org.aspectj--com.springsource.org.aspectj.runtime--1.6.0 - Eclipse Public
License 1.0
org.aspectj--com.springsource.org.aspectj.weaver--1.6.0 - Eclipse Public
License 1.0
That's as far as I can get today. Will do the rest of the review tomorrow.
Gale
On Wed, Jun 1, 2016 at 7:18 AM Stian Soiland-Reyes <st...@apache.org> wrote:
> On 1 June 2016 at 12:01, Stian Soiland-Reyes <st...@apache.org> wrote:
> > I am pleased to be calling this vote for the source release of
> >
> > Apache Taverna Engine 3.1.0-incubating
> > Apache Taverna Common Activities 2.1.0-incubating
> > Apache Taverna Command-line Tool 3.1.0-incubating
> > ..
> > Build the release candidate *in the above order*, using:
>
> Sorry I mixed up the order in the checksums which were immediately
> above in this vote email - to clarify the build order is:
>
> taverna-engine
> taverna-common-activities
> taverna-commandline
>
> The reason is that command line depends on common-activities, which
> depend on taverna-engine, all in the same version as being released.
>
>
> Perhaps for the next vote emails I will include the full URIs to the
> folders rather than just ../rc2/
>
>
> --
> Stian Soiland-Reyes
> Apache Taverna (incubating), Apache Commons
> http://orcid.org/0000-0001-9842-9718
>
Re: [VOTE] Release Apache Taverna Command-line Tool 3.1.0-incubating RC2
Posted by Stian Soiland-Reyes <st...@apache.org>.
On 1 June 2016 at 12:01, Stian Soiland-Reyes <st...@apache.org> wrote:
> I am pleased to be calling this vote for the source release of
>
> Apache Taverna Engine 3.1.0-incubating
> Apache Taverna Common Activities 2.1.0-incubating
> Apache Taverna Command-line Tool 3.1.0-incubating
> ..
> Build the release candidate *in the above order*, using:
Sorry I mixed up the order in the checksums which were immediately
above in this vote email - to clarify the build order is:
taverna-engine
taverna-common-activities
taverna-commandline
The reason is that command line depends on common-activities, which
depend on taverna-engine, all in the same version as being released.
Perhaps for the next vote emails I will include the full URIs to the
folders rather than just ../rc2/
--
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons
http://orcid.org/0000-0001-9842-9718
Re: [VOTE] Release Apache Taverna Command-line Tool 3.1.0-incubating RC2
Posted by Stian Soiland-Reyes <st...@apache.org>.
On 1 June 2016 at 12:01, Stian Soiland-Reyes <st...@apache.org> wrote:
> SHA-1 checksums:
>
> cb0176c33391d1c2d17eae973e0d665cc90bbc94
> apache-taverna-commandline-3.1.0-incubating-source-release.zip
> 1c0446734950c7360aa0d1c95952d0acb148a783
> apache-taverna-common-activities-2.1.0-incubating-source-release.zip
> a021e8b278685d25839b508b8ab727c28916325a
> apache-taverna-engine-3.1.0-incubating-source-release.zip
>
>
>
> MD5 checksums:
Sorry for copy/paste error - correct md5sums should be
db4309131f4330832736586f6357d691
apache-taverna-commandline-3.1.0-incubating-source-release.zip
03c62e8d0d8a8862638655a3591597ba
apache-taverna-common-activities-2.1.0-incubating-source-release.zip
8113656bf4ac8ed4e5ed88cb1b0da15d
apache-taverna-engine-3.1.0-incubating-source-release.zip
--
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons
http://orcid.org/0000-0001-9842-9718