You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2010/05/19 20:43:19 UTC

Re: svn commit: r946343 - in /subversion/trunk/subversion/libsvn_wc: wc_db.c wc_db_util.c wc_db_util.h

On Wed, May 19, 2010 at 15:09,  <hw...@apache.org> wrote:
> Author: hwright
> Date: Wed May 19 19:09:21 2010
> New Revision: 946343
>
> URL: http://svn.apache.org/viewvc?rev=946343&view=rev
> Log:
> Introduce another file for breaking stuff out of wc_db.c.
>
> * subversion/libsvn_wc/wc_db_util.c,
>  subversion/libsvn_wc/wc_db_util.h:
>  New.

Per IRC, I would suggest a single wc_db_private.h. Many little headers
just gets to be annoying, and I don't think this header will get
out-of-control-sized.

>...

Cheers,
-g

Re: svn commit: r946343 - in /subversion/trunk/subversion/libsvn_wc: wc_db.c wc_db_util.c wc_db_util.h

Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.

On Wed, May 19, 2010 at 3:43 PM, Greg Stein <gs...@gmail.com> wrote:

> On Wed, May 19, 2010 at 15:09,  <hw...@apache.org> wrote:
> > Author: hwright
> > Date: Wed May 19 19:09:21 2010
> > New Revision: 946343
> >
> > URL: http://svn.apache.org/viewvc?rev=946343&view=rev
> > Log:
> > Introduce another file for breaking stuff out of wc_db.c.
> >
> > * subversion/libsvn_wc/wc_db_util.c,
> >  subversion/libsvn_wc/wc_db_util.h:
> >  New.
>
> Per IRC, I would suggest a single wc_db_private.h. Many little headers
> just gets to be annoying, and I don't think this header will get
> out-of-control-sized.
>

Makes sense.  I'll combine wc_db_util.h and wc_db_pdh.h into
wc_db_private.h.

-Hyrum