[GitHub] [incubator-dubbo] chickenlj opened pull request #3126: Config center optimization

["chickenlj (GitHub)" <gi...@apache.org>]

## What is the purpose of the change

Introduce ConfigManager, a centralized place where we can store global and shared Config instances. With ConfigManager, we can solve:
1. Duplicate Config check which we have lost in the previous version (only work in Spring)
2. Make it possible for a Builder pattern, see the comments I leave in ConfigManager.java

## Brief changelog

1. Add ConfigManager
2. Related changes in several Config classes.

## Verifying this change

Run samples.

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3126 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj closed pull request #3126: Config center optimization

["chickenlj (GitHub)" <gi...@apache.org>]

[ pull request closed by chickenlj ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3126 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] khanimteyaz commented on issue #3126: Config center optimization

["khanimteyaz (GitHub)" <gi...@apache.org>]

@chickenlj this PR has some conflict could you resolve this?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3126 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj commented on issue #3126: Config center optimization

["chickenlj (GitHub)" <gi...@apache.org>]

Never mind, I will file a new one.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3126 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org