You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/25 19:12:16 UTC

[GitHub] [beam] stephenoken commented on a change in pull request #11523: [BEAM-8414] Cleanup Python codebase to enable some of the excluded Python lint checks.

stephenoken commented on a change in pull request #11523:
URL: https://github.com/apache/beam/pull/11523#discussion_r415124678



##########
File path: sdks/python/apache_beam/io/restriction_trackers.py
##########
@@ -137,7 +137,7 @@ def try_claim(self, position):
           'of the range. Tried to claim position %r for the range [%r, %r)' %
           (position, self._range.start, self._range.stop))
 
-    if position >= self._range.start and position < self._range.stop:
+    if self._range.start >= position < self._range.stop:

Review comment:
       oh my bad. thanks for catching that!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org