You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/09/05 21:54:25 UTC
[Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7963
Change subject: IMPALA-2107: [DOCS] Document base64*code() functions
......................................................................
IMPALA-2107: [DOCS] Document base64*code() functions
base64decode()
base64encode()
Change-Id: I5251e368ad36756c19a7b97e5ef6f232f616189b
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_string_functions.xml
3 files changed, 173 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/7963/1
--
To view, visit http://gerrit.cloudera.org:8080/7963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5251e368ad36756c19a7b97e5ef6f232f616189b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).
Change subject: IMPALA-2107: [DOCS] Document base64*code() functions
......................................................................
IMPALA-2107: [DOCS] Document base64*code() functions
base64decode()
base64encode()
Change-Id: I5251e368ad36756c19a7b97e5ef6f232f616189b
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_string_functions.xml
3 files changed, 173 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/7963/2
--
To view, visit http://gerrit.cloudera.org:8080/7963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5251e368ad36756c19a7b97e5ef6f232f616189b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-2107: [DOCS] Document base64*code() functions
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7963/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
Line 802: <codeph>MAX()</codeph>, and <codeph>MIN()</codeph> than when
> Are you sure about MAX and MIN? They might preserve ordering. I don't know.
Done. That was a close call that it does appear to be correct. In a sample of about a dozen words and phrases, I found almost all were sorted the same way as the unencoded values, but the 'w' entries came before the 't' ones:
| world | d29ybGQ= |
| whirled | d2hpcmxlZA== |
| whorled | d2hvcmxlZA== |
| the rain in spain | dGhlIHJhaW4gaW4gc3BhaW4= |
| the time has come | dGhlIHRpbWUgaGFzIGNvbWU= |
PS1, Line 808: All argument values
: supplied to <codeph>base64decode()</codeph> must also be a
: multiple of 4 bytes in length.
> I don't think this is right. The example you give below, for instance, is '
Right, the constraint (must be) is on base64decode argument, and the guarantee (is always) is on the base64encode return value. That was a finger fumble to say base64encode in both places.
http://gerrit.cloudera.org:8080/#/c/7963/1/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:
Line 88: <dlentry id="base64decode" rev="2.6.0 IMPALA-2107">
> This was fixed in 2.6.0, according to the ticket, not 2.9.0
Done. Changed for both base64decode and base64encode <dlentry> tags.
--
To view, visit http://gerrit.cloudera.org:8080/7963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5251e368ad36756c19a7b97e5ef6f232f616189b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2107: [DOCS] Document base64*code() functions
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5251e368ad36756c19a7b97e5ef6f232f616189b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2107: [DOCS] Document base64*code() functions
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/152/
--
To view, visit http://gerrit.cloudera.org:8080/7963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5251e368ad36756c19a7b97e5ef6f232f616189b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-2107: [DOCS] Document base64*code() functions
......................................................................
IMPALA-2107: [DOCS] Document base64*code() functions
base64decode()
base64encode()
Change-Id: I5251e368ad36756c19a7b97e5ef6f232f616189b
Reviewed-on: http://gerrit.cloudera.org:8080/7963
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: Impala Public Jenkins
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_string_functions.xml
3 files changed, 173 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Jim Apple: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5251e368ad36756c19a7b97e5ef6f232f616189b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-2107: [DOCS] Document base64*code() functions
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5251e368ad36756c19a7b97e5ef6f232f616189b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-2107: [DOCS] Document base64*code() functions
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7963/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
Line 802: <codeph>MAX()</codeph>, and <codeph>MIN()</codeph> than when
Are you sure about MAX and MIN? They might preserve ordering. I don't know.
PS1, Line 808: All argument values
: supplied to <codeph>base64encode()</codeph> must also be a
: multiple of 4 bytes in length.
I don't think this is right. The example you give below, for instance, is 'hello world', which is 11 characters.
Did you mean that all arguments to base64decode must be a multiple of 4 bytes in length?
http://gerrit.cloudera.org:8080/#/c/7963/1/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:
Line 88: <dlentry id="base64decode" rev="2.9.0 IMPALA-2107">
This was fixed in 2.6.0, according to the ticket, not 2.9.0
--
To view, visit http://gerrit.cloudera.org:8080/7963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5251e368ad36756c19a7b97e5ef6f232f616189b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: Yes