You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/24 02:21:00 UTC
[jira] [Commented] (BEAM-2644) Make it easier to test
runtime-accessible ValueProvider's
[ https://issues.apache.org/jira/browse/BEAM-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139473#comment-16139473 ]
ASF GitHub Bot commented on BEAM-2644:
--------------------------------------
GitHub user jkff opened a pull request:
https://github.com/apache/beam/pull/3753
[BEAM-2644] Introduces TestPipeline.newProvider()
R: @bjchambers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkff/incubator-beam value-provider-testing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3753.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3753
----
commit f6f9cc1353c9f6f6f14884fd1c7f7dcdd32b5fff
Author: Eugene Kirpichov <ki...@google.com>
Date: 2017-08-24T02:13:46Z
[BEAM-2644] Introduces TestPipeline.newProvider()
----
> Make it easier to test runtime-accessible ValueProvider's
> ---------------------------------------------------------
>
> Key: BEAM-2644
> URL: https://issues.apache.org/jira/browse/BEAM-2644
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Eugene Kirpichov
> Assignee: Davor Bonaci
>
> Many transforms that take ValueProvider's have different codepaths for when the provider is accessible or not. However, as far as I can tell, there is no good way to construct a transform with an inaccessible ValueProvider, and then test how it runs with an actual value supplied.
> The only way I could come up with is mimicking https://github.com/apache/beam/blob/master/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ValueProviderTest.java#L202 , which is very ugly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)