You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/05/10 06:07:56 UTC

[GitHub] [flink] SteNicholas opened a new pull request #15873: [FLINK-22413][runtime-web] Hide Checkpointing page in the UI for batch jobs

SteNicholas opened a new pull request #15873:
URL: https://github.com/apache/flink/pull/15873


   ## What is the purpose of the change
   
   *Batch jobs don't need a checkpointing page, because there is no information for these jobs available there. Therefore runtime web should hide the checkpointing page in the UI.*
   
   ## Brief change log
   
     - *The field `plan` of the response for `/jobs/:jobid` Rest API adds the `type` field which represents the job type of the job graph to identify whether the type of this job is `STREAMING` or `BATCH`.*
     - *`job-status.component.ts` hides the checkpointing page through checking the job type for the response of `/jobs/:jobid` Rest API.*
   
   ## Verifying this change
   
     - *`JsonGeneratorTest` and `JsonJobGraphGenerationTest` add the validation whether the `type` field value is equal to the job type of the job graph.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15873: [FLINK-22413][runtime-web] Hide Checkpointing page in the UI for batch jobs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15873:
URL: https://github.com/apache/flink/pull/15873#issuecomment-836227954


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 162666773fa72d571a08b1b0d55e49355f2dcca6 (Sat Aug 28 11:20:14 UTC 2021)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15873: [FLINK-22413][runtime-web] Hide Checkpointing page in the UI for batch jobs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15873:
URL: https://github.com/apache/flink/pull/15873#issuecomment-836246953


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "35b7df969a633d3ae010a369636ef6f5a20f0b57",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17770",
       "triggerID" : "35b7df969a633d3ae010a369636ef6f5a20f0b57",
       "triggerType" : "PUSH"
     }, {
       "hash" : "162666773fa72d571a08b1b0d55e49355f2dcca6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17805",
       "triggerID" : "162666773fa72d571a08b1b0d55e49355f2dcca6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 35b7df969a633d3ae010a369636ef6f5a20f0b57 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17770) 
   * 162666773fa72d571a08b1b0d55e49355f2dcca6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17805) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] SteNicholas commented on pull request #15873: [FLINK-22413][runtime-web] Hide Checkpointing page in the UI for batch jobs

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #15873:
URL: https://github.com/apache/flink/pull/15873#issuecomment-836658188


   > This appears to be a bit unreliable.
   > 
   > When running both a batch&streaming job at the same time, switching between the 2 can cause the checkpointing tab to be hidden for the streaming job.
   
   @zentol , sorry for missing the case that running both a batch&streaming job at the same time. I have addressed your comments and updated the `job-status.component.ts` for the above case. Please help to review again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #15873: [FLINK-22413][runtime-web] Hide Checkpointing page in the UI for batch jobs

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15873:
URL: https://github.com/apache/flink/pull/15873#issuecomment-836227954


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 35b7df969a633d3ae010a369636ef6f5a20f0b57 (Mon May 10 06:10:21 UTC 2021)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] zentol merged pull request #15873: [FLINK-22413][runtime-web] Hide Checkpointing page in the UI for batch jobs

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #15873:
URL: https://github.com/apache/flink/pull/15873


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #15873: [FLINK-22413][runtime-web] Hide Checkpointing page in the UI for batch jobs

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15873:
URL: https://github.com/apache/flink/pull/15873#issuecomment-836246953


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "35b7df969a633d3ae010a369636ef6f5a20f0b57",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35b7df969a633d3ae010a369636ef6f5a20f0b57",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 35b7df969a633d3ae010a369636ef6f5a20f0b57 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15873: [FLINK-22413][runtime-web] Hide Checkpointing page in the UI for batch jobs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15873:
URL: https://github.com/apache/flink/pull/15873#issuecomment-836246953


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "35b7df969a633d3ae010a369636ef6f5a20f0b57",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17770",
       "triggerID" : "35b7df969a633d3ae010a369636ef6f5a20f0b57",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 35b7df969a633d3ae010a369636ef6f5a20f0b57 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17770) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15873: [FLINK-22413][runtime-web] Hide Checkpointing page in the UI for batch jobs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15873:
URL: https://github.com/apache/flink/pull/15873#issuecomment-836246953


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "35b7df969a633d3ae010a369636ef6f5a20f0b57",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17770",
       "triggerID" : "35b7df969a633d3ae010a369636ef6f5a20f0b57",
       "triggerType" : "PUSH"
     }, {
       "hash" : "162666773fa72d571a08b1b0d55e49355f2dcca6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "162666773fa72d571a08b1b0d55e49355f2dcca6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 35b7df969a633d3ae010a369636ef6f5a20f0b57 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17770) 
   * 162666773fa72d571a08b1b0d55e49355f2dcca6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15873: [FLINK-22413][runtime-web] Hide Checkpointing page in the UI for batch jobs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15873:
URL: https://github.com/apache/flink/pull/15873#issuecomment-836246953


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "35b7df969a633d3ae010a369636ef6f5a20f0b57",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17770",
       "triggerID" : "35b7df969a633d3ae010a369636ef6f5a20f0b57",
       "triggerType" : "PUSH"
     }, {
       "hash" : "162666773fa72d571a08b1b0d55e49355f2dcca6",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17805",
       "triggerID" : "162666773fa72d571a08b1b0d55e49355f2dcca6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 162666773fa72d571a08b1b0d55e49355f2dcca6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17805) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] SteNicholas commented on pull request #15873: [FLINK-22413][runtime-web] Hide Checkpointing page in the UI for batch jobs

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #15873:
URL: https://github.com/apache/flink/pull/15873#issuecomment-836232910


   @rmetzger , @zentol , I have tested whether the Checkpointing page is hided for the Batch job and the result of the validation is worked. Please help to review this pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15873: [FLINK-22413][runtime-web] Hide Checkpointing page in the UI for batch jobs

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15873:
URL: https://github.com/apache/flink/pull/15873#issuecomment-836246953


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "35b7df969a633d3ae010a369636ef6f5a20f0b57",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17770",
       "triggerID" : "35b7df969a633d3ae010a369636ef6f5a20f0b57",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 35b7df969a633d3ae010a369636ef6f5a20f0b57 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17770) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org