[GitHub] [spark] cloud-fan commented on a change in pull request #30023: [SPARK-33126][SQL] Simplify offset window function(Remove direction field)

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #30023:
URL: https://github.com/apache/spark/pull/30023#discussion_r503937537



##########
File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/window_part1.sql.out
##########
@@ -202,7 +202,7 @@ struct<ntile(3) OVER (ORDER BY ten ASC NULLS FIRST, four ASC NULLS FIRST ROWS BE
 -- !query
 SELECT lag(ten) OVER (PARTITION BY four ORDER BY ten), ten, four FROM tenk1 WHERE unique2 < 10
 -- !query schema
-struct<lag(ten, 1, NULL) OVER (PARTITION BY four ORDER BY ten ASC NULLS FIRST ROWS BETWEEN -1 FOLLOWING AND -1 FOLLOWING):int,ten:int,four:int>
+struct<lag(ten, -1, NULL) OVER (PARTITION BY four ORDER BY ten ASC NULLS FIRST ROWS BETWEEN -1 FOLLOWING AND -1 FOLLOWING):int,ten:int,four:int>

Review comment:
       The user query is `lag(ten)`. Can we override `stringArgs` in `OffsetWindowFunction` to only include `input`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org