You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by 10110346 <gi...@git.apache.org> on 2017/05/06 08:14:42 UTC
[GitHub] spark pull request #17880: [SPARK-20620][TEST]Add some unit tests into NullE...
GitHub user 10110346 opened a pull request:
https://github.com/apache/spark/pull/17880
[SPARK-20620][TEST]Add some unit tests into NullExpressionsSuite
## What changes were proposed in this pull request?
1.add more datatype for exist unit
2.add new unit tests for other funtions
## How was this patch tested?
add new unit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/10110346/spark wip_lx_0506
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17880.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17880
----
commit f08f63dc19a2c12cee07198c7968a9be51a95360
Author: liuxian <li...@zte.com.cn>
Date: 2017-05-06T08:05:46Z
Add some unit tests into NullExpressionsSuite
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17880
**[Test build #3731 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3731/testReport)** for PR 17880 at commit [`3110f0f`](https://github.com/apache/spark/commit/3110f0f0c1a09b28a5706674ae65fd47ce48b163).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17880
**[Test build #3731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3731/testReport)** for PR 17880 at commit [`3110f0f`](https://github.com/apache/spark/commit/3110f0f0c1a09b28a5706674ae65fd47ce48b163).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17880
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77871/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17880
**[Test build #3699 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3699/testReport)** for PR 17880 at commit [`3f99750`](https://github.com/apache/spark/commit/3f99750d846dc4afe40495e0d5be972a1a292822).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17880
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17880
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Add some unit tests into NullExpressi...
Posted by 10110346 <gi...@git.apache.org>.
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/17880
@gatorsmile thanks,l will do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by 10110346 <gi...@git.apache.org>.
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/17880
done,thanks @HyukjinKwon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17880
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77507/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17880
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17880
**[Test build #77871 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77871/testReport)** for PR 17880 at commit [`5b19b91`](https://github.com/apache/spark/commit/5b19b913128fbaccc64c27c97b5ff558ef4011ed).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by 10110346 <gi...@git.apache.org>.
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/17880
I have modify `Scala style`.
Test is not started, could you help trigger it,thanks @HyukjinKwon @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17880: [SPARK-20620][TEST]Add some unit tests into NullE...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17880#discussion_r115125231
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NullExpressionsSuite.scala ---
@@ -87,24 +91,82 @@ class NullExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
}
}
- test("SPARK-16602 Nvl should support numeric-string cases") {
- def analyze(expr: Expression): Expression = {
- val relation = LocalRelation()
- SimpleAnalyzer.execute(Project(Seq(Alias(expr, "c")()), relation)).expressions.head
- }
-
+ test("coalesce -check return datatype") {
--- End diff --
This test is part of the test case `test("coalesce casts")` in `TypeCoercionSuite`. If you want, you can improve that test case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17880
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17880
**[Test build #77507 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77507/testReport)** for PR 17880 at commit [`3110f0f`](https://github.com/apache/spark/commit/3110f0f0c1a09b28a5706674ae65fd47ce48b163).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17880: [SPARK-20620][TEST]Improve some unit tests for Nu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17880
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17880: [SPARK-20620][TEST]Add some unit tests into NullE...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17880#discussion_r115125344
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NullExpressionsSuite.scala ---
@@ -87,24 +91,82 @@ class NullExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
}
}
- test("SPARK-16602 Nvl should support numeric-string cases") {
- def analyze(expr: Expression): Expression = {
- val relation = LocalRelation()
- SimpleAnalyzer.execute(Project(Seq(Alias(expr, "c")()), relation)).expressions.head
- }
-
+ test("coalesce -check return datatype") {
val intLit = Literal.create(1, IntegerType)
val doubleLit = Literal.create(2.2, DoubleType)
val stringLit = Literal.create("c", StringType)
val nullLit = Literal.create(null, NullType)
+ val floatNullLit = Literal.create(null, FloatType)
+ val floatLit = Literal.create(1.0f, FloatType)
+
+ assert(analyze(Coalesce(Seq(nullLit))).dataType == NullType)
+ assert(analyze(Coalesce(Seq(floatNullLit))).dataType == FloatType)
+ assert(analyze(Coalesce(Seq(nullLit, intLit))).dataType == IntegerType)
+ assert(analyze(Coalesce(Seq(nullLit, floatNullLit, intLit))).dataType == FloatType)
+ assert(analyze(Coalesce(Seq(nullLit, intLit, floatLit))).dataType == FloatType)
+ assert(analyze(Coalesce(Seq(nullLit, floatLit, doubleLit))).dataType == DoubleType)
+ assert(analyze(Coalesce(Seq(nullLit, intLit, floatLit, doubleLit))).dataType == DoubleType)
+ assert(analyze(Coalesce(Seq(nullLit, floatNullLit, doubleLit, stringLit))).
+ dataType == StringType)
+ assert(analyze(Coalesce(Seq(nullLit, intLit, floatLit, doubleLit, stringLit))).
+ dataType == StringType)
+ }
+ test("SPARK-16602 Nvl should support numeric-string cases") {
+ val intLit = Literal.create(1, IntegerType)
+ val doubleLit = Literal.create(2.2, DoubleType)
+ val stringLit = Literal.create("c", StringType)
+ val nullLit = Literal.create(null, NullType)
+ val floatNullLit = Literal.create(null, FloatType)
+ val floatLit = Literal.create(1.01f, FloatType)
+ val timestampLit = Literal.create("2017-04-12", TimestampType)
+ val decimalLit = Literal.create(10.2, DecimalType(20, 2))
+
+ assert(analyze(new Nvl(decimalLit, stringLit)).dataType == StringType)
+ assert(analyze(new Nvl(doubleLit, decimalLit)).dataType == DoubleType)
+ assert(analyze(new Nvl(decimalLit, doubleLit)).dataType == DoubleType)
+ assert(analyze(new Nvl(decimalLit, floatLit)).dataType == DoubleType)
+ assert(analyze(new Nvl(floatLit, decimalLit)).dataType == DoubleType)
+
+ assert(analyze(new Nvl(timestampLit, stringLit)).dataType == StringType)
assert(analyze(new Nvl(intLit, doubleLit)).dataType == DoubleType)
assert(analyze(new Nvl(intLit, stringLit)).dataType == StringType)
assert(analyze(new Nvl(stringLit, doubleLit)).dataType == StringType)
+ assert(analyze(new Nvl(doubleLit, stringLit)).dataType == StringType)
assert(analyze(new Nvl(nullLit, intLit)).dataType == IntegerType)
assert(analyze(new Nvl(doubleLit, nullLit)).dataType == DoubleType)
assert(analyze(new Nvl(nullLit, stringLit)).dataType == StringType)
+
+ assert(analyze(new Nvl(floatLit, stringLit)).dataType == StringType)
+ assert(analyze(new Nvl(floatLit, doubleLit)).dataType == DoubleType)
+ assert(analyze(new Nvl(floatNullLit, intLit)).dataType == FloatType)
+ }
+
+ test("Nvl2 -check return datatype") {
--- End diff --
The same for this. It is being covered by the test case `test("type coercion for If")` in `TypeCoercionSuite`. If you want, you can improve that test case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17880
**[Test build #3699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3699/testReport)** for PR 17880 at commit [`3f99750`](https://github.com/apache/spark/commit/3f99750d846dc4afe40495e0d5be972a1a292822).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17880: [SPARK-20620][TEST]Improve some unit tests for Nu...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17880#discussion_r115244928
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala ---
@@ -484,24 +484,50 @@ class TypeCoercionSuite extends PlanTest {
}
test("coalesce casts") {
- ruleTest(TypeCoercion.FunctionArgumentConversion,
- Coalesce(Literal(1.0)
- :: Literal(1)
- :: Literal.create(1.0, FloatType)
- :: Nil),
- Coalesce(Cast(Literal(1.0), DoubleType)
- :: Cast(Literal(1), DoubleType)
- :: Cast(Literal.create(1.0, FloatType), DoubleType)
- :: Nil))
- ruleTest(TypeCoercion.FunctionArgumentConversion,
- Coalesce(Literal(1L)
- :: Literal(1)
- :: Literal(new java.math.BigDecimal("1000000000000000000000"))
- :: Nil),
- Coalesce(Cast(Literal(1L), DecimalType(22, 0))
- :: Cast(Literal(1), DecimalType(22, 0))
- :: Cast(Literal(new java.math.BigDecimal("1000000000000000000000")), DecimalType(22, 0))
- :: Nil))
+ val rule = TypeCoercion.FunctionArgumentConversion
+
+ val intLit = Literal(1)
+ val LongLit = Literal.create(1L)
--- End diff --
(I guess this should be `longLit `)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17880
**[Test build #77507 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77507/testReport)** for PR 17880 at commit [`3110f0f`](https://github.com/apache/spark/commit/3110f0f0c1a09b28a5706674ae65fd47ce48b163).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17880
**[Test build #77871 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77871/testReport)** for PR 17880 at commit [`5b19b91`](https://github.com/apache/spark/commit/5b19b913128fbaccc64c27c97b5ff558ef4011ed).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17880
LGTM pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...
Posted by 10110346 <gi...@git.apache.org>.
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/17880
Test passed, thanks. @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17880: [SPARK-20620][TEST]Add some unit tests into NullExpressi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17880
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org