[jira] [Updated] (MAPREDUCE-5531) Binary and source incompatibility in mapreduce.TaskID and mapreduce.TaskAttemptID between branch-1 and branch-2

["Robert Kanter (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MAPREDUCE-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Kanter updated MAPREDUCE-5531:
-------------------------------------

    Attachment: MAPREDUCE-5531.patch

The patch adds the missing constructors, which simply call the other constructors.

Unit tests aren't really possible for this.
                
> Binary and source incompatibility in mapreduce.TaskID and mapreduce.TaskAttemptID between branch-1 and branch-2
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5531
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5531
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 2.1.1-beta
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>            Priority: Blocker
>         Attachments: MAPREDUCE-5531.patch
>
>
> {{mapreduce.TaskID}} in branch-1 has these two constructors:
> {code:java}
> public TaskID(JobID jobId, boolean isMap, int id)
> public TaskID(String jtIdentifier, int jobId, boolean isMap, int id)
> {code}
> In branch-2, {{mapreduce.TaskID}} no longer has either of the above two constructors.  
> Also, {{mapreduce.TaskAttemptID}} in branch-1 has this constructor:
> {code:java}
> public TaskAttemptID(String jtIdentifier, int jobId, boolean isMap, int taskId, int id)
> {code}
> In branch-2, {{mapreduce.TaskAttemptID}} no longer his this constructor.
> It looks like these constructors were probably removed because the {{boolean isMap}} was replaced by an enum, {{TaskType}}.
> This means that any code that tries to use any of those constructors will not be binary or source compatible (in fact, the missing {{TaskAttemptID}} constructor calls one of the missing {{TaskID}} constructors).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira