You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Eduardo Pérez Ureta (JIRA)" <ji...@apache.org> on 2010/11/30 21:20:11 UTC
[jira] Created: (HTTPCLIENT-1026) Properly close resources
Properly close resources
------------------------
Key: HTTPCLIENT-1026
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1026
Project: HttpComponents HttpClient
Issue Type: Bug
Components: Examples
Reporter: Eduardo Pérez Ureta
Java has exceptions so resources must always be closed on a finally clause
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCLIENT-1026) Properly close resources
Posted by "Eduardo Pérez Ureta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eduardo Pérez Ureta updated HTTPCLIENT-1026:
--------------------------------------------
Attachment: httpcomponents-client_properly_close_httpclient_fix.diff
You may want first to commit a patch to remove whitespace at the end of the line and then apply this patch.
> Properly close resources
> ------------------------
>
> Key: HTTPCLIENT-1026
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1026
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Examples
> Reporter: Eduardo Pérez Ureta
> Attachments: httpcomponents-client_properly_close_httpclient_fix.diff
>
>
> Java has exceptions so resources must always be closed on a finally clause
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCLIENT-1026) Properly close resources
Posted by "Eduardo Pérez Ureta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eduardo Pérez Ureta updated HTTPCLIENT-1026:
--------------------------------------------
Attachment: httpcomponents-client_properly_close_httpmime_fix.diff
I missed httpmime example.
Any other example?
> Properly close resources
> ------------------------
>
> Key: HTTPCLIENT-1026
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1026
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Examples
> Reporter: Eduardo Pérez Ureta
> Attachments: httpcomponents-client_properly_close_httpclient_fix.diff, httpcomponents-client_properly_close_httpmime_fix.diff
>
>
> Java has exceptions so resources must always be closed on a finally clause
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCLIENT-1026) Properly close resources
Posted by "Eduardo Pérez Ureta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eduardo Pérez Ureta updated HTTPCLIENT-1026:
--------------------------------------------
Attachment: httpcomponents-client_examples_properly_close_fix.diff
Patch against trunk
> Properly close resources
> ------------------------
>
> Key: HTTPCLIENT-1026
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1026
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Examples
> Reporter: Eduardo Pérez Ureta
> Attachments: httpcomponents-client_examples_properly_close_fix.diff, httpcomponents-client_properly_close_httpclient_fix.diff, httpcomponents-client_properly_close_httpmime_fix.diff
>
>
> Java has exceptions so resources must always be closed on a finally clause
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-1026) Properly close resources
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965472#action_12965472 ]
Oleg Kalnichevski commented on HTTPCLIENT-1026:
-----------------------------------------------
My bad. I did not look at the patch carefully enough. All examples seem there. I will review and apply the patch in the coming days.
Oleg
> Properly close resources
> ------------------------
>
> Key: HTTPCLIENT-1026
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1026
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Examples
> Reporter: Eduardo Pérez Ureta
> Attachments: httpcomponents-client_properly_close_httpclient_fix.diff, httpcomponents-client_properly_close_httpmime_fix.diff
>
>
> Java has exceptions so resources must always be closed on a finally clause
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-1026) Properly close resources
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970116#action_12970116 ]
Oleg Kalnichevski commented on HTTPCLIENT-1026:
-----------------------------------------------
Eduardo
Patches do not apply cleanly against the latest SVN trunk. Could you please create a new diff against the latest snapshot off the SVN trunk?
Oleg
> Properly close resources
> ------------------------
>
> Key: HTTPCLIENT-1026
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1026
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Examples
> Reporter: Eduardo Pérez Ureta
> Attachments: httpcomponents-client_properly_close_httpclient_fix.diff, httpcomponents-client_properly_close_httpmime_fix.diff
>
>
> Java has exceptions so resources must always be closed on a finally clause
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-1026) Properly close resources
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965445#action_12965445 ]
Oleg Kalnichevski commented on HTTPCLIENT-1026:
-----------------------------------------------
Eduardo
If you want this patch applied you should also change other examples to make them consistent.
Oleg
> Properly close resources
> ------------------------
>
> Key: HTTPCLIENT-1026
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1026
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Examples
> Reporter: Eduardo Pérez Ureta
> Attachments: httpcomponents-client_properly_close_httpclient_fix.diff
>
>
> Java has exceptions so resources must always be closed on a finally clause
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Resolved: (HTTPCLIENT-1026) Properly close resources
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved HTTPCLIENT-1026.
-------------------------------------------
Resolution: Fixed
Fix Version/s: 4.1.0
Patch checked in. Many thanks, Eduardo
Oleg
> Properly close resources
> ------------------------
>
> Key: HTTPCLIENT-1026
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1026
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Examples
> Reporter: Eduardo Pérez Ureta
> Fix For: 4.1.0
>
> Attachments: httpcomponents-client_examples_properly_close_fix.diff, httpcomponents-client_properly_close_httpclient_fix.diff, httpcomponents-client_properly_close_httpmime_fix.diff
>
>
> Java has exceptions so resources must always be closed on a finally clause
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org