You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/06/11 16:52:53 UTC
[GitHub] [commons-bcel] markro49 opened a new pull request #46: improve test case coverage; fix Utility.encode bug
markro49 opened a new pull request #46:
URL: https://github.com/apache/commons-bcel/pull/46
1) add test code for BCEL-340.
2) add new test to improve code coverage for classfile/Utility.java.
coverage increased from 40% to 72%.
3) fix bug in encode that (2) exposed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on pull request #46: improve test case coverage; fix Utility.encode bug
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #46:
URL: https://github.com/apache/commons-bcel/pull/46#issuecomment-643302510
> Oh rats - I will have to spend time writing my own comprehensive test case.
Yeah, it's pain, sorry about that, but there's not much we can do about GPL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] markro49 commented on pull request #46: improve test case coverage; fix Utility.encode bug
Posted by GitBox <gi...@apache.org>.
markro49 commented on pull request #46:
URL: https://github.com/apache/commons-bcel/pull/46#issuecomment-642977337
Oh rats - I will have to spend time writing my own comprehensive test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] garydgregory merged pull request #46: improve test case coverage; fix Utility.encode bug
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #46:
URL: https://github.com/apache/commons-bcel/pull/46
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on pull request #46: improve test case coverage; fix Utility.encode bug
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #46:
URL: https://github.com/apache/commons-bcel/pull/46#issuecomment-669430582
@markro49 ping?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on a change in pull request #46: improve test case coverage; fix Utility.encode bug
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #46:
URL: https://github.com/apache/commons-bcel/pull/46#discussion_r439098739
##########
File path: src/test/java/org/apache/bcel/data/DummySignatureParser.java
##########
@@ -0,0 +1,1049 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.bcel.data;
+
+/*
+ * The following code is taken from the JDK 8 sources for sun.reflect.generics.
+ * It has been modified to compile stand alone within the BCEL test environment.
+ * The code is not executed but the classfile is used as input to a BCEL test case.
+ */
+
+/*
Review comment:
-1: We cannot include GPL 2 or GPL 3 code. Please see:
- https://www.apache.org/licenses/GPL-compatibility.html
- https://www.apache.org/foundation/license-faq.html#GPL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org