You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/19 15:52:15 UTC

[GitHub] [maven] michael-o commented on a diff in pull request #878: [MNG-7541] Implement powershell command

michael-o commented on code in PR #878:
URL: https://github.com/apache/maven/pull/878#discussion_r1027108363


##########
apache-maven/src/assembly/shared/mvnvalidate.ps1:
##########
@@ -0,0 +1,9 @@
+# check mvn home
+if (-not $env:MAVEN_HOME) {
+    $env:MAVEN_HOME = (Get-Item $PSScriptRoot"\..")
+}

Review Comment:
   This is wrong. `MAVEN_HOME` is neither an environment variable, nor can it be passed externally. It is solely private. See https://github.com/apache/maven/blob/29283a10596c92a9283d789d4c661dd242cec916/apache-maven/src/assembly/shared/mvnvalidate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org