You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/05/26 09:07:34 UTC
[GitHub] matthiasblaesing commented on a change in pull request #561: Removing GPL licenses from nbbuild/licenses, and a lot of various ref…
matthiasblaesing commented on a change in pull request #561: Removing GPL licenses from nbbuild/licenses, and a lot of various ref…
URL: https://github.com/apache/incubator-netbeans/pull/561#discussion_r191043525
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/CreateDependencies.java
##########
@@ -107,7 +107,7 @@ public void setSourceDependencies(boolean sourceDependencies) {
Map<String, Map<String, Set<String>>> dependenciesDesc = new LinkedHashMap<>();
dependenciesDesc.put("Runtime dependencies:", origin2TextsRuntime);
- if (sourceDependencies) {
+ if (sourceDependencies && /*don't print the compile-time dependencies*/false) {
Review comment:
Was the DEPENDENCIES file part of critique? If it was, I'm fine with the change, if not, I think we should retain the compile-time dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists