[jira] [Resolved] (SPARK-8541) sumApprox and meanApprox doctests are incorrect

["Josh Rosen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Josh Rosen resolved SPARK-8541.
-------------------------------
       Resolution: Fixed
    Fix Version/s: 1.5.0
                   1.3.2
                   1.4.2

Fixed by https://github.com/apache/spark/pull/6942

> sumApprox and meanApprox doctests are incorrect
> -----------------------------------------------
>
>                 Key: SPARK-8541
>                 URL: https://issues.apache.org/jira/browse/SPARK-8541
>             Project: Spark
>          Issue Type: Test
>          Components: PySpark
>    Affects Versions: 1.3.1, 1.4.0
>            Reporter: Scott Taylor
>            Assignee: Scott Taylor
>            Priority: Minor
>              Labels: tests
>             Fix For: 1.4.2, 1.3.2, 1.5.0
>
>
> The doctests for sumApprox and meanApprox methods test against an upper bound but not a lower bound. If there was a regression in the underlying code that caused things to go wrong the doctest may not fail. For example if sumApprox returned 0 the doctest would return -1 which is less than 0.05. Solution is to use the abs() function to test that the approximate answer is within 5% of the exact answer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org