You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by de...@apache.org on 2013/08/09 13:38:38 UTC

svn commit: r1512265 - in /maven/shared/trunk/maven-mapping/src/main/java/org/apache/maven/shared/mapping: DashClassifierValueSource.java MappingUtils.java

Author: dennisl
Date: Fri Aug  9 11:38:38 2013
New Revision: 1512265

URL: http://svn.apache.org/r1512265
Log:
Improve Javadoc.

Modified:
    maven/shared/trunk/maven-mapping/src/main/java/org/apache/maven/shared/mapping/DashClassifierValueSource.java
    maven/shared/trunk/maven-mapping/src/main/java/org/apache/maven/shared/mapping/MappingUtils.java

Modified: maven/shared/trunk/maven-mapping/src/main/java/org/apache/maven/shared/mapping/DashClassifierValueSource.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-mapping/src/main/java/org/apache/maven/shared/mapping/DashClassifierValueSource.java?rev=1512265&r1=1512264&r2=1512265&view=diff
==============================================================================
--- maven/shared/trunk/maven-mapping/src/main/java/org/apache/maven/shared/mapping/DashClassifierValueSource.java (original)
+++ maven/shared/trunk/maven-mapping/src/main/java/org/apache/maven/shared/mapping/DashClassifierValueSource.java Fri Aug  9 11:38:38 2013
@@ -29,7 +29,6 @@ import org.codehaus.plexus.interpolation
  * <code>dashClassifier?</code>.
  *
  * @version $Id$
- * @since 2.5
  */
 public class DashClassifierValueSource
     extends PropertiesBasedValueSource

Modified: maven/shared/trunk/maven-mapping/src/main/java/org/apache/maven/shared/mapping/MappingUtils.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-mapping/src/main/java/org/apache/maven/shared/mapping/MappingUtils.java?rev=1512265&r1=1512264&r2=1512265&view=diff
==============================================================================
--- maven/shared/trunk/maven-mapping/src/main/java/org/apache/maven/shared/mapping/MappingUtils.java (original)
+++ maven/shared/trunk/maven-mapping/src/main/java/org/apache/maven/shared/mapping/MappingUtils.java Fri Aug  9 11:38:38 2013
@@ -25,19 +25,26 @@ import org.codehaus.plexus.interpolation
 import org.codehaus.plexus.interpolation.RegexBasedInterpolator;
 
 /**
+ * <p>
  * Utilities used to evaluate expression.
- * <p/>
- * TODO: this comes from the assembly plugin; refactor when it's shared.
- * <p/>
+ * </p>
+ * <p>
  * The expression might use any field of the {@link Artifact} interface. Some
  * examples might be:
+ * </p>
  * <ul>
  * <li>@{artifactId}@-@{version}@@{dashClassifier?}@.@{extension}@</li>
  * <li>@{artifactId}@-@{version}@.@{extension}@</li>
  * <li>@{artifactId}@.@{extension}@</li>
  * </ul>
+ * <p>
+ * Although parts of this code comes from the Assembly Plugin, it cannot be
+ * shared with the Assembly Plugin. The reason for this is that the Assembly
+ * Plugin always uses a prefix for the expressions, whereas this code does not.
+ * <p/>
  *
  * @author Stephane Nicoll
+ * @author Dennis Lundberg
  * @version $Id$
  */
 public class MappingUtils