You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by randerzander <gi...@git.apache.org> on 2017/03/10 05:03:25 UTC
[GitHub] zeppelin pull request #2117: ZEPPELIN-2241: JDBC interpreter throws npe on c...
GitHub user randerzander opened a pull request:
https://github.com/apache/zeppelin/pull/2117
ZEPPELIN-2241: JDBC interpreter throws npe on connecting to any db that has a schema with "null" name
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
Prevents JDBC interpreter from throwing a stacktrace when the database has a schema with no name (null).
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
https://issues.apache.org/jira/browse/ZEPPELIN-2241
### How should this be tested?
Outline the steps to test the PR here.
Use JDBC interpreter to connect to any database that has a schema without a name. Apache Phoenix in particular has such a schema by default.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/randerzander/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2117
----
commit 0101296833161629609eef71b5df904152f15841
Author: Randy Gelhausen <rg...@gmail.com>
Date: 2017-03-10T04:59:59Z
ZEPPELIN-2241: JDBC interpreter throws npe on connecting to any db that has a schema with "null" name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2117: ZEPPELIN-2241: JDBC interpreter throws npe on connecti...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2117
@randerzander Hi, you can restart the failed job again using the `restart` button.
If you close / open this PR after all jobs pass, you can see this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2117: ZEPPELIN-2241: JDBC interpreter throws npe on c...
Posted by randerzander <gi...@git.apache.org>.
Github user randerzander closed the pull request at:
https://github.com/apache/zeppelin/pull/2117
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2117: ZEPPELIN-2241: JDBC interpreter throws npe on c...
Posted by randerzander <gi...@git.apache.org>.
Github user randerzander closed the pull request at:
https://github.com/apache/zeppelin/pull/2117
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2117: ZEPPELIN-2241: JDBC interpreter throws npe on c...
Posted by randerzander <gi...@git.apache.org>.
GitHub user randerzander reopened a pull request:
https://github.com/apache/zeppelin/pull/2117
ZEPPELIN-2241: JDBC interpreter throws npe on connecting to any db that has a schema with "null" name
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
Prevents JDBC interpreter from throwing a stacktrace when the database has a schema with no name (null).
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
https://issues.apache.org/jira/browse/ZEPPELIN-2241
### How should this be tested?
Outline the steps to test the PR here.
Use JDBC interpreter to connect to any database that has a schema without a name. Apache Phoenix in particular has such a schema by default.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/randerzander/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2117
----
commit 0101296833161629609eef71b5df904152f15841
Author: Randy Gelhausen <rg...@gmail.com>
Date: 2017-03-10T04:59:59Z
ZEPPELIN-2241: JDBC interpreter throws npe on connecting to any db that has a schema with "null" name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2117: ZEPPELIN-2241: JDBC interpreter throws npe on connecti...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2117
LGTM and merge to master and branch-0.7, if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2117: ZEPPELIN-2241: JDBC interpreter throws npe on c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2117
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2117: ZEPPELIN-2241: JDBC interpreter throws npe on connecti...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2117
LGTM except one minor thing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2117: ZEPPELIN-2241: JDBC interpreter throws npe on connecti...
Posted by randerzander <gi...@git.apache.org>.
Github user randerzander commented on the issue:
https://github.com/apache/zeppelin/pull/2117
Thanks for the link, @1ambda . Do I need to close and re-open the PR to get Travis to run the test now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2117: ZEPPELIN-2241: JDBC interpreter throws npe on connecti...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2117
I will test and give you feed back soon!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2117: ZEPPELIN-2241: JDBC interpreter throws npe on connecti...
Posted by randerzander <gi...@git.apache.org>.
Github user randerzander commented on the issue:
https://github.com/apache/zeppelin/pull/2117
@1ambda I enabled Travis for my repo. All builds passed except [this one](https://travis-ci.org/randerzander/zeppelin/jobs/209828896) which unrelated errors about Pig/MapReduce.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2117: ZEPPELIN-2241: JDBC interpreter throws npe on connecti...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2117
Hi @randerzander. Thanks for contribution.
- Zeppelin build system relies on travis. So please setup your travis account and travis project for Zeppelin.
- https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2117: ZEPPELIN-2241: JDBC interpreter throws npe on c...
Posted by randerzander <gi...@git.apache.org>.
GitHub user randerzander reopened a pull request:
https://github.com/apache/zeppelin/pull/2117
ZEPPELIN-2241: JDBC interpreter throws npe on connecting to any db that has a schema with "null" name
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
Prevents JDBC interpreter from throwing a stacktrace when the database has a schema with no name (null).
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
https://issues.apache.org/jira/browse/ZEPPELIN-2241
### How should this be tested?
Outline the steps to test the PR here.
Use JDBC interpreter to connect to any database that has a schema without a name. Apache Phoenix in particular has such a schema by default.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/randerzander/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2117
----
commit 0101296833161629609eef71b5df904152f15841
Author: Randy Gelhausen <rg...@gmail.com>
Date: 2017-03-10T04:59:59Z
ZEPPELIN-2241: JDBC interpreter throws npe on connecting to any db that has a schema with "null" name
commit 79d8a234d3d43bca1c3735a0ed2b2a37c8fc581e
Author: Randy Gelhausen <rg...@gmail.com>
Date: 2017-03-10T17:43:37Z
Added comment to the change
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---