You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2019/11/09 08:04:41 UTC

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #4282: Add test for the qnn_add operator

FrozenGene commented on a change in pull request #4282: Add test for the qnn_add operator
URL: https://github.com/apache/incubator-tvm/pull/4282#discussion_r344433873
 
 

 ##########
 File path: tests/python/frontend/tflite/test_forward.py
 ##########
 @@ -624,17 +661,23 @@ def _test_greater(data):
     """ One iteration of greater """
     return _test_elemwise(math_ops.greater, data)
 
-def _test_forward_elemwise(testop):
+def _test_forward_elemwise(testop, quantized=False):
 
 Review comment:
   I agree we separate int8 / fp32 two isolated functions, because we have others functions, like fully_connected, we could do it the same too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services