You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/05 22:41:57 UTC

[GitHub] apeforest commented on a change in pull request #11982: Fix undefined variable errors

apeforest commented on a change in pull request #11982: Fix undefined variable errors
URL: https://github.com/apache/incubator-mxnet/pull/11982#discussion_r207750794
 
 

 ##########
 File path: example/ssd/dataset/pycocotools/coco.py
 ##########
 @@ -255,22 +255,23 @@ def showAnns(self, anns):
                             color.append(c)
                     else:
                         # mask
-                        t = self.imgs[ann['image_id']]
-                        if type(ann['segmentation']['counts']) == list:
+                        raise NotImplementedError("maskUtils disabled!")
+                        # t = self.imgs[ann['image_id']]
+                        # if type(ann['segmentation']['counts']) == list:
                             # rle = maskUtils.frPyObjects([ann['segmentation']], t['height'], t['width'])
-                            raise NotImplementedError("maskUtils disabled!")
-                        else:
-                            rle = [ann['segmentation']]
+                        #    raise NotImplementedError("maskUtils disabled!")
 
 Review comment:
   If these are not needed, I would prefer just removing them instead of commenting out.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services