[GitHub] [madlib] fmcquillan99 commented on pull request #534: DL: Various docs changes

[GitBox <gi...@apache.org>]

fmcquillan99 commented on pull request #534:
URL: https://github.com/apache/madlib/pull/534#issuecomment-783803053


   @orhankislal 
   
   missing 'loss_type' in output table from
   .../workspace/madlib/build_docker/doc/user/html/group__grp__keras.html#keras_fit
   
   I think we missed this in 
   https://github.com/apache/madlib/pull/511
   where we added to info table for multi_fit() but forgot fit()
   
   can you add it in please?  thx
   
   ```
   -[ RECORD 1 ]-------------+--------------------------------------------------------------------------
   source_table              | iris_train_packed
   model                     | iris_model
   dependent_varname         | {class_text}
   independent_varname       | {attributes}
   model_arch_table          | model_arch_library
   model_id                  | 1
   compile_params            |  loss='categorical_crossentropy', optimizer='adam', metrics=['accuracy'] 
   fit_params                |  batch_size=5, epochs=3 
   num_iterations            | 10
   validation_table          | 
   object_table              | 
   metrics_compute_frequency | 10
   name                      | 
   description               | 
   model_type                | madlib_keras
   model_size                | 0.7900390625
   start_training_time       | 2021-02-22 22:39:59.223927
   end_training_time         | 2021-02-22 22:40:02.695402
   metrics_elapsed_time      | {3.47141289710999}
   madlib_version            | 1.18.0-dev
   num_classes               | {3}
   dependent_vartype         | {"character varying"}
   normalizing_const         | 1
   metrics_type              | {accuracy}
   loss_type				  | xxxyyyzzz                        <- **** missing ****
   training_metrics_final    | 0.833333313465118
   training_loss_final       | 0.745647132396698
   training_metrics          | {0.833333313465118}
   training_loss             | {0.745647132396698}
   validation_metrics_final  | 
   validation_loss_final     | 
   validation_metrics        | 
   validation_loss           | 
   metrics_iters             | {10}
   class_text_class_values   | {Iris-setosa,Iris-versicolor,Iris-virginica}
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org