[jira] [Commented] (ZOOKEEPER-2060) Deadlock in NettyServerCnxnFactory

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171376#comment-14171376 ] 

Hadoop QA commented on ZOOKEEPER-2060:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12674807/ZOOKEEPER-2060.patch
  against trunk revision 1631280.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2389//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2389//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2389//console

This message is automatically generated.

> Deadlock in NettyServerCnxnFactory
> ----------------------------------
>
>                 Key: ZOOKEEPER-2060
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2060
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.6, 3.5.0
>            Reporter: Ian Dimayuga
>            Assignee: Ian Dimayuga
>             Fix For: 3.4.7, 3.5.1
>
>         Attachments: ZOOKEEPER-2060.patch, ZOOKEEPER-2060_deadlock_jstack.txt
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> In NettyServerCnxnFactory, high throughput triggers a deadlock.
> This is caused by a channel-buffer-dumping debug statement in NettyServerCnxnFactory.java that is executed regardless of log level.
> This code path only executes when the server is throttling, but when it does it encounters a race and occasional deadlock between the channel buffer and NettyServerCnxn (jstack attached).
> The proposed fix adds the debug logging guard to this statement, similar to other existing statements.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)