You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/23 05:48:00 UTC

[GitHub] [flink] rmetzger opened a new pull request #13757: [FLINK-18117][e2e] Add debugging information for hadoop startup

rmetzger opened a new pull request #13757:
URL: https://github.com/apache/flink/pull/13757


   
   ## What is the purpose of the change
   
   This adds some non-invasive environment debugging to understand why the namenode can not allocate the http port inside a docker container.
   I was not able to reproduce the failing e2e test.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13757: [FLINK-18117][e2e] Add debugging information for hadoop startup

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13757:
URL: https://github.com/apache/flink/pull/13757#issuecomment-714945768


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b2cc9638a9d919e924a4a67b8d15e68e4dad530d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8151",
       "triggerID" : "b2cc9638a9d919e924a4a67b8d15e68e4dad530d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b2cc9638a9d919e924a4a67b8d15e68e4dad530d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8151) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger commented on a change in pull request #13757: [FLINK-18117][e2e] Add debugging information for hadoop startup

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #13757:
URL: https://github.com/apache/flink/pull/13757#discussion_r510845732



##########
File path: flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/bootstrap.sh
##########
@@ -92,7 +92,12 @@ if [ "$1" == "--help" -o "$1" == "-h" ]; then
     exit 0
 elif [ "$1" == "master" ]; then
     yes| sudo -E -u hdfs $HADOOP_PREFIX/bin/hdfs namenode -format
-
+    sudo -E sudo netstat -tulpn >> /var/log/hadoop/debugging.out
+    echo "--------------------" >> /var/log/hadoop/debugging.out
+    sudo -E sudo ps -aux >> /var/log/hadoop/debugging.out
+    echo "--------------------" >> /var/log/hadoop/debugging.out
+    sudo -E sudo jps -v >> /var/log/hadoop/debugging.out

Review comment:
       oh, that's clearly a mistake. Good catch! I'll fix it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] XComp commented on a change in pull request #13757: [FLINK-18117][e2e] Add debugging information for hadoop startup

Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #13757:
URL: https://github.com/apache/flink/pull/13757#discussion_r510842846



##########
File path: flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/bootstrap.sh
##########
@@ -92,7 +92,12 @@ if [ "$1" == "--help" -o "$1" == "-h" ]; then
     exit 0
 elif [ "$1" == "master" ]; then
     yes| sudo -E -u hdfs $HADOOP_PREFIX/bin/hdfs namenode -format
-
+    sudo -E sudo netstat -tulpn >> /var/log/hadoop/debugging.out

Review comment:
       Just as a side-note: I usually added also `-e` as a parameter getting "extended" output. Not sure whether it helps in that case but it's just nice to read for someone who knows German: `netstat -tulpen` 😄 

##########
File path: flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/bootstrap.sh
##########
@@ -92,7 +92,12 @@ if [ "$1" == "--help" -o "$1" == "-h" ]; then
     exit 0
 elif [ "$1" == "master" ]; then
     yes| sudo -E -u hdfs $HADOOP_PREFIX/bin/hdfs namenode -format
-
+    sudo -E sudo netstat -tulpn >> /var/log/hadoop/debugging.out
+    echo "--------------------" >> /var/log/hadoop/debugging.out
+    sudo -E sudo ps -aux >> /var/log/hadoop/debugging.out
+    echo "--------------------" >> /var/log/hadoop/debugging.out
+    sudo -E sudo jps -v >> /var/log/hadoop/debugging.out

Review comment:
       Are you sure that you want to use `sudo -E sudo #...`? I couldn't test it quickly but it looks strange.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger commented on pull request #13757: [FLINK-18117][e2e] Add debugging information for hadoop startup

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13757:
URL: https://github.com/apache/flink/pull/13757#issuecomment-715335612


   Thanks a lot for your review. Merging ...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13757: [FLINK-18117][e2e] Add debugging information for hadoop startup

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13757:
URL: https://github.com/apache/flink/pull/13757#issuecomment-714929264


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit b2cc9638a9d919e924a4a67b8d15e68e4dad530d (Fri Oct 23 05:50:17 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13757: [FLINK-18117][e2e] Add debugging information for hadoop startup

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13757:
URL: https://github.com/apache/flink/pull/13757#issuecomment-714945768


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b2cc9638a9d919e924a4a67b8d15e68e4dad530d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8151",
       "triggerID" : "b2cc9638a9d919e924a4a67b8d15e68e4dad530d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b2cc9638a9d919e924a4a67b8d15e68e4dad530d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8151) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger commented on a change in pull request #13757: [FLINK-18117][e2e] Add debugging information for hadoop startup

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #13757:
URL: https://github.com/apache/flink/pull/13757#discussion_r510845555



##########
File path: flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/bootstrap.sh
##########
@@ -92,7 +92,12 @@ if [ "$1" == "--help" -o "$1" == "-h" ]; then
     exit 0
 elif [ "$1" == "master" ]; then
     yes| sudo -E -u hdfs $HADOOP_PREFIX/bin/hdfs namenode -format
-
+    sudo -E sudo netstat -tulpn >> /var/log/hadoop/debugging.out

Review comment:
       I tried the -e argument, but it only adds things like "package count" per port, which is not relevant for understanding who's allocating the port. (I copy pasted "tulpn" from somewhere, and also remembered the -e)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger merged pull request #13757: [FLINK-18117][e2e] Add debugging information for hadoop startup

Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #13757:
URL: https://github.com/apache/flink/pull/13757


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13757: [FLINK-18117][e2e] Add debugging information for hadoop startup

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13757:
URL: https://github.com/apache/flink/pull/13757#issuecomment-714945768


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b2cc9638a9d919e924a4a67b8d15e68e4dad530d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b2cc9638a9d919e924a4a67b8d15e68e4dad530d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b2cc9638a9d919e924a4a67b8d15e68e4dad530d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org