You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/07/23 16:53:23 UTC

Review Request 12858: CLOUDSTACK-3724: Test case "test_vpc_vms_deployment.py" failed to find network offering.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12858/
-----------------------------------------------------------

Review request for cloudstack and Prasanna Santhanam.


Bugs: CLOUDSTACK-3724


Repository: cloudstack-git


Description
-------

CLOUDSTACK-3724: Test case "test_vpc_vms_deployment.py" failed to find network offering.

The test_script was broken because "nw_off" got appended twice for cleanup instead of "nw_off_no_lb".


Diffs
-----

  test/integration/component/test_vpc_vms_deployment.py c599d96 

Diff: https://reviews.apache.org/r/12858/diff/


Testing
-------

Verified the marvin test locally on cloudstack setup.


Thanks,

Sanjay Tripathi


Re: Review Request 12858: CLOUDSTACK-3724: Test case "test_vpc_vms_deployment.py" failed to find network offering.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12858/#review23752
-----------------------------------------------------------


Commit 74ac8575b09427c7511272bdd6592df092b55112 in branch refs/heads/4.2 from Prasanna Santhanam
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=74ac857 ]

CLOUDSTACK-3724: optimizing cleanup

Signed-off-by: Prasanna Santhanam <ts...@apache.org>


- ASF Subversion and Git Services


On July 23, 2013, 2:53 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12858/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 2:53 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3724
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3724: Test case "test_vpc_vms_deployment.py" failed to find network offering.
> 
> The test_script was broken because "nw_off" got appended twice for cleanup instead of "nw_off_no_lb".
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_vpc_vms_deployment.py c599d96 
> 
> Diff: https://reviews.apache.org/r/12858/diff/
> 
> 
> Testing
> -------
> 
> Verified the marvin test locally on cloudstack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 12858: CLOUDSTACK-3724: Test case "test_vpc_vms_deployment.py" failed to find network offering.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12858/#review23699
-----------------------------------------------------------


Commit a06b3f40eba6ebc3af5d7c366ec757703a085f67 in branch refs/heads/4.2 from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a06b3f4 ]

CLOUDSTACK-3724: Test case "test_vpc_vms_deployment.py" failed to find network offering.

Signed-off-by: Prasanna Santhanam <ts...@apache.org>


- ASF Subversion and Git Services


On July 23, 2013, 2:53 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12858/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 2:53 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3724
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3724: Test case "test_vpc_vms_deployment.py" failed to find network offering.
> 
> The test_script was broken because "nw_off" got appended twice for cleanup instead of "nw_off_no_lb".
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_vpc_vms_deployment.py c599d96 
> 
> Diff: https://reviews.apache.org/r/12858/diff/
> 
> 
> Testing
> -------
> 
> Verified the marvin test locally on cloudstack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 12858: CLOUDSTACK-3724: Test case "test_vpc_vms_deployment.py" failed to find network offering.

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12858/#review23701
-----------------------------------------------------------

Ship it!


Ship It!

- Prasanna Santhanam


On July 23, 2013, 2:53 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12858/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 2:53 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3724
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3724: Test case "test_vpc_vms_deployment.py" failed to find network offering.
> 
> The test_script was broken because "nw_off" got appended twice for cleanup instead of "nw_off_no_lb".
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_vpc_vms_deployment.py c599d96 
> 
> Diff: https://reviews.apache.org/r/12858/diff/
> 
> 
> Testing
> -------
> 
> Verified the marvin test locally on cloudstack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 12858: CLOUDSTACK-3724: Test case "test_vpc_vms_deployment.py" failed to find network offering.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12858/#review23704
-----------------------------------------------------------


Commit 5c45645932f7537aa93f4d060e114a40dc7cbcb6 in branch refs/heads/master from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5c45645 ]

CLOUDSTACK-3724: Test case "test_vpc_vms_deployment.py" failed to find network offering.

Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit a06b3f40eba6ebc3af5d7c366ec757703a085f67)


- ASF Subversion and Git Services


On July 23, 2013, 2:53 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12858/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 2:53 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3724
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3724: Test case "test_vpc_vms_deployment.py" failed to find network offering.
> 
> The test_script was broken because "nw_off" got appended twice for cleanup instead of "nw_off_no_lb".
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_vpc_vms_deployment.py c599d96 
> 
> Diff: https://reviews.apache.org/r/12858/diff/
> 
> 
> Testing
> -------
> 
> Verified the marvin test locally on cloudstack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 12858: CLOUDSTACK-3724: Test case "test_vpc_vms_deployment.py" failed to find network offering.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12858/#review23749
-----------------------------------------------------------


Commit 2b8f1bde8f8e3c399baf44695c10866798e1fe45 in branch refs/heads/master from Prasanna Santhanam
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2b8f1bd ]

CLOUDSTACK-3724: optimizing cleanup

Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit 8b7d00ee4de53d15a1d495c3c1fdd166b1651460)


- ASF Subversion and Git Services


On July 23, 2013, 2:53 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12858/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 2:53 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3724
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3724: Test case "test_vpc_vms_deployment.py" failed to find network offering.
> 
> The test_script was broken because "nw_off" got appended twice for cleanup instead of "nw_off_no_lb".
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_vpc_vms_deployment.py c599d96 
> 
> Diff: https://reviews.apache.org/r/12858/diff/
> 
> 
> Testing
> -------
> 
> Verified the marvin test locally on cloudstack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>