You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/03/29 01:18:50 UTC

[GitHub] [dubbo] wangchengming666 commented on issue #9847: org.apache.dubbo.metadata.definition.builder.MapTypeBuilder#build写死actualTypeArgsLength==2??

wangchengming666 commented on issue #9847:
URL: https://github.com/apache/dubbo/issues/9847#issuecomment-1081302264


   翻了以前的一些issue 比如 #8212 和 #5122 都提到过这个问题,我认为这段强校验的代码没必要存在。
   ```
           if (actualTypeArgsLength != 2) {
               throw new IllegalArgumentException(MessageFormat.format(
                       "[ServiceDefinitionBuilder] Map type [{0}] with unexpected amount of arguments [{1}]."
                               + Arrays.toString(actualTypeArgs), type, actualTypeArgs));
           }
   ```
   虽然可以通过SPI来扩展,但是还是得用户带来了一定的困扰。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org