You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by charsyam <gi...@git.apache.org> on 2015/05/16 19:13:54 UTC
[GitHub] tajo pull request: TAJO-1607 Tajo Rest Cache-Id should be bigger t...
GitHub user charsyam opened a pull request:
https://github.com/apache/tajo/pull/572
TAJO-1607 Tajo Rest Cache-Id should be bigger than zero
currently, tajo rest api can return cache-id that is smaller than 0.
but it is not beautiful, so I think it is better cache id is begger than 0
```
{'link': 'http://127.0.0.1:26880/rest/databases/default/queries/q_1431795664397_0008/result/-2197002215675989303', 'id': -2197002215675989303}
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/charsyam/tajo feature/create-cache-id-overzero
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/572.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #572
----
commit 592be400c1a523bbb2ccd6ad9837151e571429b4
Author: clark.kang <cl...@kakao.com>
Date: 2015-05-16T17:09:27Z
cache-id should be unsigned
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1607 Tajo Rest Cache-Id should be bigger t...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/572#issuecomment-103007089
@charsyam I've just committed it to master branch. I missed to add an github command to close this issue. Could you please close this ticket?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1607 Tajo Rest Cache-Id should be bigger t...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/572#issuecomment-103005840
+1
the change looks straightforward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1607 Tajo Rest Cache-Id should be bigger t...
Posted by charsyam <gi...@git.apache.org>.
Github user charsyam closed the pull request at:
https://github.com/apache/tajo/pull/572
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---