You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/09/14 13:46:04 UTC

[GitHub] andrzej-kaczmarek opened a new pull request #1399: [DONOTMERGE] RTT console fixes

andrzej-kaczmarek opened a new pull request #1399: [DONOTMERGE] RTT console fixes
URL: https://github.com/apache/mynewt-core/pull/1399
 
 
   This fixes 2 problems with RTT console:
   1. output data may be corrupted
   2. output data may be skipped when writing lots of data at once to RTT
   
   1st problem is because we write data using function which can overwrite existing data in buffer - this should not be used when host is reading data since both sides may modify write pointer without sync (thus data corruption). to resolve this we use proper function which skips data instead of overwriting - this is safe
   2d problem is because we can write data to RTT quickly, but host reads data by polling periodically thus it may not start reading data when we fill buffer. to solve this we will now wait a bit when buffer is full and retry which gives host some time to start reading data. retry number and delay is configurable. also we will not retry if detcted that host is not reading data at all
   
   NOTE: this is DONOTMERGE since it depdends on some other patches which should go into separate PRs (like https://github.com/apache/mynewt-core/pull/1395) - so just for testing now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services