You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "oowl (via GitHub)" <gi...@apache.org> on 2023/08/23 14:37:36 UTC
[GitHub] [incubator-opendal] oowl opened a new pull request, #2915: feat(types): add stat_with API for blocking operator
oowl opened a new pull request, #2915:
URL: https://github.com/apache/incubator-opendal/pull/2915
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #2915: feat(types): add stat_with API for blocking operator
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2915:
URL: https://github.com/apache/incubator-opendal/pull/2915#issuecomment-1690153534
> Maybe we need to fire a ticket to sync the operator and blocking operator API Semantics
Some API like sink are not implemented for blocking API. We can add them when we have those needs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] oowl commented on pull request #2915: feat(types): add stat_with API for blocking operator
Posted by "oowl (via GitHub)" <gi...@apache.org>.
oowl commented on PR #2915:
URL: https://github.com/apache/incubator-opendal/pull/2915#issuecomment-1690107629
> What's the gap?
For example `FunctionWrite` and `FutureWrite`, The functions of two should be the same, but in reality, there are differences between them. This is because we did not implement these APIs together.
For example https://github.com/apache/incubator-opendal/blob/main/core/src/types/operator/operator_futures.rs#L385 and https://github.com/apache/incubator-opendal/blob/main/core/src/types/operator/operator_functions.rs#L78
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] suyanhanx commented on pull request #2915: feat(types): add stat_with API for blocking operator
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #2915:
URL: https://github.com/apache/incubator-opendal/pull/2915#issuecomment-1690111989
You are right. We may need to check all of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #2915: feat(types): add stat_with API for blocking operator
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #2915:
URL: https://github.com/apache/incubator-opendal/pull/2915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] oowl commented on pull request #2915: feat(types): add stat_with API for blocking operator
Posted by "oowl (via GitHub)" <gi...@apache.org>.
oowl commented on PR #2915:
URL: https://github.com/apache/incubator-opendal/pull/2915#issuecomment-1690090297
@xuanwo I found blocking operator has some API gap compared with the async operator, Maybe we need to fire a ticket to sync the operator and blocking operator API API Semantics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] suyanhanx commented on pull request #2915: feat(types): add stat_with API for blocking operator
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #2915:
URL: https://github.com/apache/incubator-opendal/pull/2915#issuecomment-1690094440
What's the gap?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] oowl commented on pull request #2915: feat(types): add stat_with API for blocking operator
Posted by "oowl (via GitHub)" <gi...@apache.org>.
oowl commented on PR #2915:
URL: https://github.com/apache/incubator-opendal/pull/2915#issuecomment-1691734203
> @Xuanwo I found blocking operator has some API gap compared with the async operator, Maybe we need to fire a ticket to sync the operator and blocking operator API Semantics
https://github.com/apache/incubator-opendal/pull/2924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org