[GitHub] [pinot] sajjad-moradi commented on a diff in pull request #10964: Allow custom segment grouping in MergeRollupTask based on lineage metadata

["sajjad-moradi (via GitHub)" <gi...@apache.org>]

sajjad-moradi commented on code in PR #10964:
URL: https://github.com/apache/pinot/pull/10964#discussion_r1242797215


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/lineage/DefaultLineageManager.java:
##########
@@ -105,6 +107,11 @@ public void updateLineageForRetention(TableConfig tableConfig, SegmentLineage li
     }
   }
 
+  @Override
+  public List<List<SegmentZKMetadata>> getSegmentGroupsForMergeRollupTask(TableConfig tableConfig,

Review Comment:
   +1
   This logic belongs to MergeRollup, not LineageManager. Let's create an interface like MergeRollupSegmentGroupManager, MergeRollupSegmentCategorizer, or something like these, and inject the interface into MergeRollupTaskGenerator.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org