You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "V.V.Chaitanya Krishna (JIRA)" <ji...@apache.org> on 2010/04/29 05:04:48 UTC
[jira] Created: (PIG-1396) eclipse-files target in build.xml fails
to generate necessary classes in src-gen
eclipse-files target in build.xml fails to generate necessary classes in src-gen
--------------------------------------------------------------------------------
Key: PIG-1396
URL: https://issues.apache.org/jira/browse/PIG-1396
Project: Pig
Issue Type: Bug
Components: build
Affects Versions: 0.8.0
Reporter: V.V.Chaitanya Krishna
Fix For: 0.8.0
With PIG-1390 checked in, ant eclipse-files does only the ivy-download part but does not compile and generate the necessary classes in src-gen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1396) eclipse-files target in build.xml
fails to generate necessary classes in src-gen
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862418#action_12862418 ]
Hadoop QA commented on PIG-1396:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12443165/PIG-1396.patch
against trunk revision 938733.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/304/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/304/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/304/console
This message is automatically generated.
> eclipse-files target in build.xml fails to generate necessary classes in src-gen
> --------------------------------------------------------------------------------
>
> Key: PIG-1396
> URL: https://issues.apache.org/jira/browse/PIG-1396
> Project: Pig
> Issue Type: Bug
> Components: build
> Affects Versions: 0.8.0
> Reporter: V.V.Chaitanya Krishna
> Assignee: V.V.Chaitanya Krishna
> Fix For: 0.8.0
>
> Attachments: PIG-1396.patch
>
>
> With PIG-1390 checked in, ant eclipse-files does only the ivy-download part but does not compile and generate the necessary classes in src-gen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (PIG-1396) eclipse-files target in build.xml fails
to generate necessary classes in src-gen
Posted by "V.V.Chaitanya Krishna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.V.Chaitanya Krishna reassigned PIG-1396:
------------------------------------------
Assignee: V.V.Chaitanya Krishna
> eclipse-files target in build.xml fails to generate necessary classes in src-gen
> --------------------------------------------------------------------------------
>
> Key: PIG-1396
> URL: https://issues.apache.org/jira/browse/PIG-1396
> Project: Pig
> Issue Type: Bug
> Components: build
> Affects Versions: 0.8.0
> Reporter: V.V.Chaitanya Krishna
> Assignee: V.V.Chaitanya Krishna
> Fix For: 0.8.0
>
>
> With PIG-1390 checked in, ant eclipse-files does only the ivy-download part but does not compile and generate the necessary classes in src-gen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1396) eclipse-files target in build.xml fails
to generate necessary classes in src-gen
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair updated PIG-1396:
-------------------------------
Status: Patch Available (was: Open)
> eclipse-files target in build.xml fails to generate necessary classes in src-gen
> --------------------------------------------------------------------------------
>
> Key: PIG-1396
> URL: https://issues.apache.org/jira/browse/PIG-1396
> Project: Pig
> Issue Type: Bug
> Components: build
> Affects Versions: 0.8.0
> Reporter: V.V.Chaitanya Krishna
> Assignee: V.V.Chaitanya Krishna
> Fix For: 0.8.0
>
> Attachments: PIG-1396.patch
>
>
> With PIG-1390 checked in, ant eclipse-files does only the ivy-download part but does not compile and generate the necessary classes in src-gen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1396) eclipse-files target in build.xml
fails to generate necessary classes in src-gen
Posted by "V.V.Chaitanya Krishna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862518#action_12862518 ]
V.V.Chaitanya Krishna commented on PIG-1396:
--------------------------------------------
bq. -1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
Since this is a build change and more specifically, it's a change that is in action only while importing to eclipse. So, it cannot be unit-tested, unlike other patches.
bq. -1 core tests. The patch failed core unit tests.
I don't think this failure is related to this patch because as mentioned before, it's a build change that is used only for eclipse environment issues and this should not hinder the running of ant targets that are responsible for running testcases.
> eclipse-files target in build.xml fails to generate necessary classes in src-gen
> --------------------------------------------------------------------------------
>
> Key: PIG-1396
> URL: https://issues.apache.org/jira/browse/PIG-1396
> Project: Pig
> Issue Type: Bug
> Components: build
> Affects Versions: 0.8.0
> Reporter: V.V.Chaitanya Krishna
> Assignee: V.V.Chaitanya Krishna
> Fix For: 0.8.0
>
> Attachments: PIG-1396.patch
>
>
> With PIG-1390 checked in, ant eclipse-files does only the ivy-download part but does not compile and generate the necessary classes in src-gen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1396) eclipse-files target in build.xml fails
to generate necessary classes in src-gen
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair updated PIG-1396:
-------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
Thanks Chaitanya.
I have committed the patch along with some changes to the indentation, and also updated the instructions in http://wiki.apache.org/pig/Eclipse_Environment .
> eclipse-files target in build.xml fails to generate necessary classes in src-gen
> --------------------------------------------------------------------------------
>
> Key: PIG-1396
> URL: https://issues.apache.org/jira/browse/PIG-1396
> Project: Pig
> Issue Type: Bug
> Components: build
> Affects Versions: 0.8.0
> Reporter: V.V.Chaitanya Krishna
> Assignee: V.V.Chaitanya Krishna
> Fix For: 0.8.0
>
> Attachments: PIG-1396.patch
>
>
> With PIG-1390 checked in, ant eclipse-files does only the ivy-download part but does not compile and generate the necessary classes in src-gen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.