You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by hi...@gmail.com on 2012/01/27 21:18:02 UTC
Review Request: RAVE-425
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3667/
-----------------------------------------------------------
Review request for rave.
Summary
-------
This is a patch to add a category filter to the widget store. RAVE-435
Diffs
-----
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1236813
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1236813
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java 1236813
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1236813
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1236813
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1236813
trunk/rave-portal-resources/src/main/resources/messages.properties 1236813
trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1236813
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1236813
trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1236813
Diff: https://reviews.apache.org/r/3667/diff
Testing
-------
Thanks,
hilker.j
Re: Review Request: RAVE-435
Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3667/#review4689
-----------------------------------------------------------
Ship it!
This looks good - I will apply.
- Anthony
On 2012-01-30 14:53:32, hilker.j wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3667/
> -----------------------------------------------------------
>
> (Updated 2012-01-30 14:53:32)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> This is a patch to add a category filter to the widget store. RAVE-435
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1237650
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1237650
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java 1237650
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1237650
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1237650
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1237650
> trunk/rave-portal-resources/src/main/resources/messages.properties 1237650
> trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1237650
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1237650
> trunk/rave-portal-resources/src/main/webapp/css/default.css 1237650
> trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1237650
>
> Diff: https://reviews.apache.org/r/3667/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> hilker.j
>
>
Re: Review Request: RAVE-435
Posted by hi...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3667/
-----------------------------------------------------------
(Updated 2012-01-30 14:53:32.725073)
Review request for rave.
Summary
-------
This is a patch to add a category filter to the widget store. RAVE-435
Diffs (updated)
-----
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1237650
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1237650
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java 1237650
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1237650
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1237650
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1237650
trunk/rave-portal-resources/src/main/resources/messages.properties 1237650
trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1237650
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1237650
trunk/rave-portal-resources/src/main/webapp/css/default.css 1237650
trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1237650
Diff: https://reviews.apache.org/r/3667/diff
Testing
-------
Thanks,
hilker.j
Re: Review Request: RAVE-435
Posted by hi...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3667/
-----------------------------------------------------------
(Updated 2012-01-30 14:48:58.882673)
Review request for rave.
Changes
-------
Minor changes based on review
Summary
-------
This is a patch to add a category filter to the widget store. RAVE-435
Diffs (updated)
-----
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaCategoryRepository.java 1237650
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1237650
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1237650
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java 1237650
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1237650
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1237650
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1237650
trunk/rave-portal-resources/src/main/resources/messages.properties 1237650
trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1237650
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1237650
trunk/rave-portal-resources/src/main/webapp/css/default.css 1237650
trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1237650
Diff: https://reviews.apache.org/r/3667/diff
Testing
-------
Thanks,
hilker.j
Re: Review Request: RAVE-435
Posted by hi...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3667/
-----------------------------------------------------------
(Updated 2012-01-27 20:18:20.091325)
Review request for rave.
Summary (updated)
-------
This is a patch to add a category filter to the widget store. RAVE-435
Diffs
-----
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1236813
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1236813
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java 1236813
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1236813
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1236813
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1236813
trunk/rave-portal-resources/src/main/resources/messages.properties 1236813
trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1236813
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1236813
trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1236813
Diff: https://reviews.apache.org/r/3667/diff
Testing
-------
Thanks,
hilker.j