[GitHub] [incubator-iceberg] rdblue opened a new pull request #650: Refactor in and notIn expressions

[GitBox <gi...@apache.org>]

rdblue opened a new pull request #650: Refactor in and notIn expressions
URL: https://github.com/apache/incubator-iceberg/pull/650
 
 
   #594 added support for in and notIn expressions using a new `BoundSetExpression` class. That class was not a child of `BoundExpression`, so new methods were added to `ExpressionVisitor`. This also requires new methods in `Transform` to implement projection. Instead of adding these new methods, this refactors bound expressions into 3 type: unary (isNull, isNaN), single literal (comparison), and literal set bound expressions that all extend `BoundExpression`.
   
   #594 also added two new `Set` implementations, `LiteralSet` and `CharSeqLiteralSet`, and used multiple sets for each predicate: one to pass values to `UnboundPredicate`, a set of `Literal` during binding, and a final `LiteralSet`. This makes the `CharSeqLiteralSet` a util set implementation and simplifies the value handling.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org