You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/10/19 18:40:24 UTC
[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7149: Use "twelve" as the password where "twelve12" was used
zrhoffman opened a new pull request, #7149:
URL: https://github.com/apache/trafficcontrol/pull/7149
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
#4764 changed the default password in some places, but not all, from `twelve` to `twelve12`. This is confusing for all of the people who are used to `twelve` being the default password for all components of the project. This PR reverts all instances of `twelve12` to `twelve`.
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- CDN in a Box
- CDN in a Box for Developers
- Traffic Portal
- Traffic Portal v2
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
Verify the tests pass
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #7149: Use "twelve" as the password where "twelve12" was used
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on PR #7149:
URL: https://github.com/apache/trafficcontrol/pull/7149#issuecomment-1292288893
I don't agree that we should knowingly use invalid data in any environment, except in a test to ensure such data is rejected by the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use "twelve" as the password where "twelve12" was used [trafficcontrol]
Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 commented on PR #7149:
URL: https://github.com/apache/trafficcontrol/pull/7149#issuecomment-1831233573
If `twelve12` would be rejected by the API then it shouldn't be in use either. It does, at least, meet the requirements in TP(v1), but really we should have a password that will be accepted. Like `twelve12!` (I hope; I didn't check).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use "twelve" as the password where "twelve12" was used [trafficcontrol]
Posted by "zrhoffman (via GitHub)" <gi...@apache.org>.
zrhoffman commented on PR #7149:
URL: https://github.com/apache/trafficcontrol/pull/7149#issuecomment-1830867693
> I don't agree that we should knowingly use invalid data in any environment, except in a test to ensure such data is rejected by the API.
`twelve12` is in `invalid_passwords.txt` (as is `twelve`), it would be rejected by the API. But using `twelve12` detracts from usability, and keeping `twelve` does not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use "twelve" as the password where "twelve12" was used [trafficcontrol]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7149:
URL: https://github.com/apache/trafficcontrol/pull/7149#issuecomment-1830867694
## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7149?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`7a3e1e0`)](https://app.codecov.io/gh/apache/trafficcontrol/commit/7a3e1e0f5566b315252ad8bc9bfe195cc8807096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 28.96% compared to head [(`e2ebbce`)](https://app.codecov.io/gh/apache/trafficcontrol/pull/7149?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 65.64%.
> Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #7149 +/- ##
=============================================
+ Coverage 28.96% 65.64% +36.68%
Complexity 98 98
=============================================
Files 602 323 -279
Lines 77452 12836 -64616
Branches 90 970 +880
=============================================
- Hits 22432 8426 -14006
+ Misses 52926 4050 -48876
+ Partials 2094 360 -1734
```
| [Flag](https://app.codecov.io/gh/apache/trafficcontrol/pull/7149/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [golib_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7149/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [grove_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7149/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [t3c_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7149/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [traffic_monitor_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7149/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [traffic_ops_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7149/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [traffic_portal_v2](https://app.codecov.io/gh/apache/trafficcontrol/pull/7149/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.35% <100.00%> (?)` | |
| [traffic_stats_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7149/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit_tests](https://app.codecov.io/gh/apache/trafficcontrol/pull/7149/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.35% <100.00%> (+48.55%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/trafficcontrol/pull/7149?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use "twelve" as the password where "twelve12" was used [trafficcontrol]
Posted by "mitchell852 (via GitHub)" <gi...@apache.org>.
mitchell852 commented on PR #7149:
URL: https://github.com/apache/trafficcontrol/pull/7149#issuecomment-1830859413
how about using `password` as the password? that meets the 8 character requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org