You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/02/04 20:23:59 UTC
[jira] Created: (ZOOKEEPER-291) regression for legacy code using
KeeperException.Code constants (due to 246)
regression for legacy code using KeeperException.Code constants (due to 246)
----------------------------------------------------------------------------
Key: ZOOKEEPER-291
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291
Project: Zookeeper
Issue Type: Bug
Components: java client
Reporter: Patrick Hunt
Fix For: 3.1.0
In 246 the old constants were deprecated and replace with enum. In the process usage of the orig constants was broken for switch statements, cases require compiletime constants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-291) regression for legacy code using
KeeperException.Code constants (due to 246)
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-291:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. THnaks pat.
> regression for legacy code using KeeperException.Code constants (due to 246)
> ----------------------------------------------------------------------------
>
> Key: ZOOKEEPER-291
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-291.patch
>
>
> In 246 the old constants were deprecated and replace with enum. In the process usage of the orig constants was broken for switch statements, cases require compiletime constants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-291) regression for legacy code using
KeeperException.Code constants (due to 246)
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-291:
-----------------------------------
Attachment: ZOOKEEPER-291.patch
I added tests (that failed w/o the changes) to verify that legacy code will work ok using the deprecated constants in switch case statements.
Also added tests to make sure the new enums work too :-)
> regression for legacy code using KeeperException.Code constants (due to 246)
> ----------------------------------------------------------------------------
>
> Key: ZOOKEEPER-291
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-291.patch
>
>
> In 246 the old constants were deprecated and replace with enum. In the process usage of the orig constants was broken for switch statements, cases require compiletime constants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-291) regression for legacy code using
KeeperException.Code constants (due to 246)
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670435#action_12670435 ]
Mahadev konar commented on ZOOKEEPER-291:
-----------------------------------------
+1 for the patch.
> regression for legacy code using KeeperException.Code constants (due to 246)
> ----------------------------------------------------------------------------
>
> Key: ZOOKEEPER-291
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-291.patch
>
>
> In 246 the old constants were deprecated and replace with enum. In the process usage of the orig constants was broken for switch statements, cases require compiletime constants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-291) regression for legacy code using
KeeperException.Code constants (due to 246)
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-291:
-----------------------------------
Status: Patch Available (was: Open)
Please review and commit this patch - it needs to be committed to both the trunk and also the 3.1 branch. At the same time be sure to edit the CHANGES.txt (again both main/branch) to specify that 246 was an incompatible change (this one is just a bug).
I will ensure this is in the release notes for 3.1 release.
> regression for legacy code using KeeperException.Code constants (due to 246)
> ----------------------------------------------------------------------------
>
> Key: ZOOKEEPER-291
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-291.patch
>
>
> In 246 the old constants were deprecated and replace with enum. In the process usage of the orig constants was broken for switch statements, cases require compiletime constants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-291) regression for legacy code using
KeeperException.Code constants (due to 246)
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-291:
--------------------------------------
Assignee: Patrick Hunt
> regression for legacy code using KeeperException.Code constants (due to 246)
> ----------------------------------------------------------------------------
>
> Key: ZOOKEEPER-291
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.1.0
>
>
> In 246 the old constants were deprecated and replace with enum. In the process usage of the orig constants was broken for switch statements, cases require compiletime constants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-291) regression for legacy code using
KeeperException.Code constants (due to 246)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671104#action_12671104 ]
Hudson commented on ZOOKEEPER-291:
----------------------------------
Integrated in ZooKeeper-trunk #221 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/221/])
> regression for legacy code using KeeperException.Code constants (due to 246)
> ----------------------------------------------------------------------------
>
> Key: ZOOKEEPER-291
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-291.patch
>
>
> In 246 the old constants were deprecated and replace with enum. In the process usage of the orig constants was broken for switch statements, cases require compiletime constants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.