[Rust][Datafusion] Dataframe api sync send

[Anıl Chalil <an...@globalmaksimum.com>]

Hi,
I am new to rust so my question can be nonsense so thank you for your
patience in advance. I am trying implement a small single node query
service and it will return its data over grpc(not flight). When i try to
use execution context and dataframe api behind a tonic service,compiler
gives error:
the trait Sync is not implemented for dyn datafusion::dataframe::DataFrame
as i understand all futures should be sync+send for tonic and currently
dataframe api is not sync+send. Are there any plans to make it sync+send?
Or should i look for other ways to implement it?Currently i am using this
method
https://docs.rs/tokio/1.1.1/tokio/task/struct.LocalSet.html#use-inside-tokiospawn

Best Regards...

Re: [Rust][Datafusion] Dataframe api sync send

[Andrew Lamb <al...@influxdata.com>]

Awesome -- I polished up the PR and I think it is now ready to review.
Hopefully we'll get it merged in (assuming there are no objections) in the
next few days

Andrew

On Wed, Feb 3, 2021 at 6:17 PM Anıl Chalil <an...@globalmaksimum.com>
wrote:

> Hi Andrew,
>
> Yes this is what i look for. Thank you for your help and waiting for merge.
>
> On Wed, Feb 3, 2021, 8:50 PM Andrew Lamb <al...@influxdata.com> wrote:
>
>> Hi Anil,
>>
>>  I don't know of any specific plans to make DataFrame Send+Sync, but I
>> gave it a quick shot: https://github.com/apache/arrow/pull/9406
>>
>> And it seems to work -- if this is the change you are looking for? If so
>> I can polish up that PR and get it ready for review and hopefully merged
>> soon
>>
>> Andrew
>>
>> On Wed, Feb 3, 2021 at 6:46 AM Anıl Chalil <an...@globalmaksimum.com>
>> wrote:
>>
>>> Hi,
>>> I am new to rust so my question can be nonsense so thank you for your
>>> patience in advance. I am trying implement a small single node query
>>> service and it will return its data over grpc(not flight). When i try to
>>> use execution context and dataframe api behind a tonic service,compiler
>>> gives error:
>>> the trait Sync is not implemented for dyn
>>> datafusion::dataframe::DataFrame
>>> as i understand all futures should be sync+send for tonic and currently
>>> dataframe api is not sync+send. Are there any plans to make it sync+send?
>>> Or should i look for other ways to implement it?Currently i am using this
>>> method
>>>
>>> https://docs.rs/tokio/1.1.1/tokio/task/struct.LocalSet.html#use-inside-tokiospawn
>>>
>>> Best Regards...
>>>
>>

Re: [Rust][Datafusion] Dataframe api sync send

[Anıl Chalil <an...@globalmaksimum.com>]

Hi Andrew,

Yes this is what i look for. Thank you for your help and waiting for merge.

On Wed, Feb 3, 2021, 8:50 PM Andrew Lamb <al...@influxdata.com> wrote:

> Hi Anil,
>
>  I don't know of any specific plans to make DataFrame Send+Sync, but I
> gave it a quick shot: https://github.com/apache/arrow/pull/9406
>
> And it seems to work -- if this is the change you are looking for? If so I
> can polish up that PR and get it ready for review and hopefully merged soon
>
> Andrew
>
> On Wed, Feb 3, 2021 at 6:46 AM Anıl Chalil <an...@globalmaksimum.com>
> wrote:
>
>> Hi,
>> I am new to rust so my question can be nonsense so thank you for your
>> patience in advance. I am trying implement a small single node query
>> service and it will return its data over grpc(not flight). When i try to
>> use execution context and dataframe api behind a tonic service,compiler
>> gives error:
>> the trait Sync is not implemented for dyn
>> datafusion::dataframe::DataFrame
>> as i understand all futures should be sync+send for tonic and currently
>> dataframe api is not sync+send. Are there any plans to make it sync+send?
>> Or should i look for other ways to implement it?Currently i am using this
>> method
>>
>> https://docs.rs/tokio/1.1.1/tokio/task/struct.LocalSet.html#use-inside-tokiospawn
>>
>> Best Regards...
>>
>

Re: [Rust][Datafusion] Dataframe api sync send

[Andrew Lamb <al...@influxdata.com>]

Hi Anil,

 I don't know of any specific plans to make DataFrame Send+Sync, but I gave
it a quick shot: https://github.com/apache/arrow/pull/9406

And it seems to work -- if this is the change you are looking for? If so I
can polish up that PR and get it ready for review and hopefully merged soon

Andrew

On Wed, Feb 3, 2021 at 6:46 AM Anıl Chalil <an...@globalmaksimum.com>
wrote:

> Hi,
> I am new to rust so my question can be nonsense so thank you for your
> patience in advance. I am trying implement a small single node query
> service and it will return its data over grpc(not flight). When i try to
> use execution context and dataframe api behind a tonic service,compiler
> gives error:
> the trait Sync is not implemented for dyn datafusion::dataframe::DataFrame
> as i understand all futures should be sync+send for tonic and currently
> dataframe api is not sync+send. Are there any plans to make it sync+send?
> Or should i look for other ways to implement it?Currently i am using this
> method
>
> https://docs.rs/tokio/1.1.1/tokio/task/struct.LocalSet.html#use-inside-tokiospawn
>
> Best Regards...
>