You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/10/27 14:06:33 UTC
[jira] [Commented] (SHINDIG-1651) Security tokens aren't returned
on the iframeurl as part of a metadata response when the gadget uses OAuth
[ https://issues.apache.org/jira/browse/SHINDIG-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136985#comment-13136985 ]
jiraposter@reviews.apache.org commented on SHINDIG-1651:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2572/
-----------------------------------------------------------
(Updated 2011-10-27 12:06:49.082022)
Review request for shindig and Brian Lillie.
Changes
-------
Sorry Ryan, I thought I had added JIRA. Patch included in the JIRA and linked to in the review.
Summary
-------
If a gadget uses OAuth but requires no other features that depend on the "security-token" feature, a security token is not returned on the iframeurl when it should be. This stems from the fact that ModulePrefs.getViewFeatures() doesn't pick up the artificially added "security-token" feature that gets added by the FeatureVisitor if the OAuthVisitors found oauth tags.
This addresses bug SHINDIG-1651.
https://issues.apache.org/jira/browse/SHINDIG-1651
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java 1189151
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/ModulePrefsTest.java 1189151
Diff: https://reviews.apache.org/r/2572/diff
Testing
-------
Updated existing JUnits and added new JUnits.
Thanks,
Stanton
> Security tokens aren't returned on the iframeurl as part of a metadata response when the gadget uses OAuth
> ----------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1651
> URL: https://issues.apache.org/jira/browse/SHINDIG-1651
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Fix For: 3.0.0
>
> Attachments: ModulePrefsSecurityTokenPatch.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> If a gadget uses OAuth but requires no other features that depend on the "security-token" feature, a security token is not returned on the iframeurl when it should be. This stems from the fact that ModulePrefs.getViewFeatures() doesn't pick up the artificially added "security-token" feature that gets added by the FeatureVisitor if the OAuthVisitors found oauth tags.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira