You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/05/12 02:41:01 UTC

[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1114: ORC-1170:[C++] Optimize the RowReader::seekToRow function

dongjoon-hyun commented on code in PR #1114:
URL: https://github.com/apache/orc/pull/1114#discussion_r870900068


##########
c++/include/orc/MemoryPool.hh:
##########
@@ -72,6 +72,10 @@ namespace orc {
       return currentCapacity;
     }
 
+    const T& operator[](uint64_t i) const {
+      return buf[i];
+    }
+

Review Comment:
   Does this part have a big impact?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org