You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/20 15:47:06 UTC
[GitHub] [airflow] andriisoldatenko opened a new pull request #13791: add ability to pass region_name to EmrAddStepsOperator
andriisoldatenko opened a new pull request #13791:
URL: https://github.com/apache/airflow/pull/13791
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #13791: add ability to pass region_name to EmrAddStepsOperator
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #13791:
URL: https://github.com/apache/airflow/pull/13791#issuecomment-773777799
> possible fix for #13785
this is not strictly necessary, and not strictly a bug. region is configurable in the airflow connection (and if using system creds, of course configurable on your system).
you add kwargs for aws client by putting `config_kwargs` in conn extra: https://github.com/apache/airflow/blob/master/airflow/providers/amazon/aws/hooks/base_aws.py#L371
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #13791: add ability to pass region_name to EmrAddStepsOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #13791:
URL: https://github.com/apache/airflow/pull/13791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on a change in pull request #13791: add ability to pass region_name to EmrAddStepsOperator
Posted by GitBox <gi...@apache.org>.
RosterIn commented on a change in pull request #13791:
URL: https://github.com/apache/airflow/pull/13791#discussion_r561295609
##########
File path: airflow/providers/amazon/aws/operators/emr_add_steps.py
##########
@@ -73,9 +74,10 @@ def __init__(
self.job_flow_name = job_flow_name
self.cluster_states = cluster_states
self.steps = steps
+ self.region_name = region_name
Review comment:
```suggestion
self.region_name = region_name
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13791: add ability to pass region_name to EmrAddStepsOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13791:
URL: https://github.com/apache/airflow/pull/13791#issuecomment-807788198
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on a change in pull request #13791: add ability to pass region_name to EmrAddStepsOperator
Posted by GitBox <gi...@apache.org>.
RosterIn commented on a change in pull request #13791:
URL: https://github.com/apache/airflow/pull/13791#discussion_r561295609
##########
File path: airflow/providers/amazon/aws/operators/emr_add_steps.py
##########
@@ -73,9 +74,10 @@ def __init__(
self.job_flow_name = job_flow_name
self.cluster_states = cluster_states
self.steps = steps
+ self.region_name = region_name
Review comment:
```suggestion
self.region_name = region_name
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13791: add ability to pass region_name to EmrAddStepsOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13791:
URL: https://github.com/apache/airflow/pull/13791#issuecomment-763820249
[The Workflow run](https://github.com/apache/airflow/actions/runs/499156609) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle commented on pull request #13791: add ability to pass region_name to EmrAddStepsOperator
Posted by GitBox <gi...@apache.org>.
feluelle commented on pull request #13791:
URL: https://github.com/apache/airflow/pull/13791#issuecomment-771007790
I re-ran the jobs, because one was failing(, I think unrelated).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13791: add ability to pass region_name to EmrAddStepsOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13791:
URL: https://github.com/apache/airflow/pull/13791#issuecomment-771044839
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle commented on pull request #13791: add ability to pass region_name to EmrAddStepsOperator
Posted by GitBox <gi...@apache.org>.
feluelle commented on pull request #13791:
URL: https://github.com/apache/airflow/pull/13791#issuecomment-775027486
True. But it is a "possible fix" isn't it?
It still makes sense to configure the region at this stage. We also have done this for other aws operator as far as I remember.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #13791: add ability to pass region_name to EmrAddStepsOperator
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #13791:
URL: https://github.com/apache/airflow/pull/13791#issuecomment-773777799
> possible fix for #13785
this is not strictly necessary, and not strictly a bug. region is configurable in the airflow connection (and if using system creds, of course configurable on your system).
you add kwargs for aws client by putting `config_kwargs` in conn extra: https://github.com/apache/airflow/blob/master/airflow/providers/amazon/aws/hooks/base_aws.py#L371
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #13791: add ability to pass region_name to EmrAddStepsOperator
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #13791:
URL: https://github.com/apache/airflow/pull/13791#issuecomment-775054002
yeah my offering of that solution with the status quo is not meant to indicate oppostion, just saying, you can to this with airflow conn and that's what that user ought to do
having this kindof thing also configurable as params can be convenient and i offer no objection to its addition here :)
small correction on my comment above... as ash pointed out on that issue ... you can put region at top level in conn extra (i think the key is `region_name` and don't need to nest it under `config_kwargs`... a little easier that way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org