You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by jk...@apache.org on 2014/07/18 09:37:29 UTC
git commit: Revert "update ANTLR to 3.5.2,
fixes issues when building the grammar with Java 8" Less4j is not
compatible with ANTLR 3.5
Repository: tapestry-5
Updated Branches:
refs/heads/master 2667b5a9d -> 4bd6302e0
Revert "update ANTLR to 3.5.2, fixes issues when building the grammar with Java 8"
Less4j is not compatible with ANTLR 3.5
This reverts commit 7702038519af9a548de52b757446b02212f7165f.
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/4bd6302e
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/4bd6302e
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/4bd6302e
Branch: refs/heads/master
Commit: 4bd6302e0eca754b86e0cb2a9a0ab1ec6270857c
Parents: 2667b5a
Author: Jochen Kemnade <jo...@eddyson.de>
Authored: Fri Jul 18 09:36:22 2014 +0200
Committer: Jochen Kemnade <jo...@eddyson.de>
Committed: Fri Jul 18 09:36:32 2014 +0200
----------------------------------------------------------------------
tapestry-core/build.gradle | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4bd6302e/tapestry-core/build.gradle
----------------------------------------------------------------------
diff --git a/tapestry-core/build.gradle b/tapestry-core/build.gradle
index c16cd48..41c2adf 100644
--- a/tapestry-core/build.gradle
+++ b/tapestry-core/build.gradle
@@ -27,12 +27,12 @@ dependencies {
compile "commons-codec:commons-codec:1.5"
// Transitive will bring in the unwanted string template library as well
- compile "org.antlr:antlr-runtime:3.5.2", {
+ compile "org.antlr:antlr-runtime:3.3", {
exclude group: "org.antlr", module: "stringtemplate"
}
// Antlr3 tool path used with the antlr3 task
- antlr3 "org.antlr:antlr:3.5.2"
+ antlr3 "org.antlr:antlr:3.3"
testRuntime "org.hsqldb:hsqldb:1.8.0.10"
}
Re: git commit: Revert "update ANTLR to 3.5.2, fixes issues when
building the grammar with Java 8" Less4j is not compatible with ANTLR 3.5
Posted by Howard Lewis Ship <hl...@gmail.com>.
Yep, just hit this.
java.lang.NoSuchFieldError: EOF_TOKEN
at com.github.sommeri.less4j.core.parser.LessLexer.nextToken(LessLexer.java:218)
at com.github.sommeri.less4j.core.parser.CollectorTokenSource.nextToken(ANTLRParser.java:191)
at com.github.sommeri.less4j.core.parser.CollectorTokenSource.nextToken(ANTLRParser.java:172)
at org.antlr.runtime.BufferedTokenStream.fetch(BufferedTokenStream.java:143)
at org.antlr.runtime.BufferedTokenStream.sync(BufferedTokenStream.java:137)
at org.antlr.runtime.CommonTokenStream.consume(CommonTokenStream.java:71)
at org.antlr.runtime.BaseRecognizer.match(BaseRecognizer.java:106)
at com.github.sommeri.less4j.core.parser.LessParser.imports(LessParser.java:633)
at com.github.sommeri.less4j.core.parser.LessParser.top_level_element(LessParser.java:3168)
at com.github.sommeri.less4j.core.parser.LessParser.styleSheet(LessParser.java:307)
at com.github.sommeri.less4j.core.parser.ANTLRParser$InputType$5.parseTree(ANTLRParser.java:157)
at com.github.sommeri.less4j.core.parser.ANTLRParser.parse(ANTLRParser.java:67)
at com.github.sommeri.less4j.core.parser.ANTLRParser.parseStyleSheet(ANTLRParser.java:35)
at com.github.sommeri.less4j.core.ThreadUnsafeLessCompiler.toAntlrTree(ThreadUnsafeLessCompiler.java:93)
at com.github.sommeri.less4j.core.ThreadUnsafeLessCompiler.doCompile(ThreadUnsafeLessCompiler.java:82)
at com.github.sommeri.less4j.core.ThreadUnsafeLessCompiler.compile(ThreadUnsafeLessCompiler.java:74)
at com.github.sommeri.less4j.core.DefaultLessCompiler.compile(DefaultLessCompiler.java:56)
at com.fivoosh.services.less4j.LessJavaScriptResourceTransformer.compile(LessJavaScriptResourceTransformer.java:24)
at org.apache.tapestry5.internal.webresources.LessResourceTransformer.invokeLessCompiler(LessResourceTransformer.java:59)
at org.apache.tapestry5.internal.webresources.LessResourceTransformer.transform(LessResourceTransformer.java:48)
at org.apache.tapestry5.internal.webresources.ResourceTransformerFactoryImpl$1$1.perform(ResourceTransformerFactoryImpl.java:148)
at org.apache.tapestry5.internal.webresources.ResourceTransformerFactoryImpl$1$1.perform(ResourceTransformerFactoryImpl.java:144)
at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.perform(OperationTrackerImpl.java:110)
On Fri, Jul 18, 2014 at 9:10 AM, Jochen Kemnade <ke...@gmail.com> wrote:
> Yes, i had also run the tests. It has to do with the version overrides, see
> my other mails from earlier today.
> Am 18.07.2014 17:47 schrieb "Howard Lewis Ship" <hl...@gmail.com>:
>
> > This is very surprising, as I ran the full test suite with this change in
> > place, and the Less4J related code in tapestry-webresources worked
> > properly. What are the symptoms?
> >
> >
> > On Fri, Jul 18, 2014 at 12:37 AM, <jk...@apache.org> wrote:
> >
> > > Repository: tapestry-5
> > > Updated Branches:
> > > refs/heads/master 2667b5a9d -> 4bd6302e0
> > >
> > >
> > > Revert "update ANTLR to 3.5.2, fixes issues when building the grammar
> > with
> > > Java 8"
> > > Less4j is not compatible with ANTLR 3.5
> > >
> > > This reverts commit 7702038519af9a548de52b757446b02212f7165f.
> > >
> > >
> > > Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
> > > Commit:
> > http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/4bd6302e
> > > Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/4bd6302e
> > > Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/4bd6302e
> > >
> > > Branch: refs/heads/master
> > > Commit: 4bd6302e0eca754b86e0cb2a9a0ab1ec6270857c
> > > Parents: 2667b5a
> > > Author: Jochen Kemnade <jo...@eddyson.de>
> > > Authored: Fri Jul 18 09:36:22 2014 +0200
> > > Committer: Jochen Kemnade <jo...@eddyson.de>
> > > Committed: Fri Jul 18 09:36:32 2014 +0200
> > >
> > > ----------------------------------------------------------------------
> > > tapestry-core/build.gradle | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > ----------------------------------------------------------------------
> > >
> > >
> > >
> > >
> >
> http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4bd6302e/tapestry-core/build.gradle
> > > ----------------------------------------------------------------------
> > > diff --git a/tapestry-core/build.gradle b/tapestry-core/build.gradle
> > > index c16cd48..41c2adf 100644
> > > --- a/tapestry-core/build.gradle
> > > +++ b/tapestry-core/build.gradle
> > > @@ -27,12 +27,12 @@ dependencies {
> > > compile "commons-codec:commons-codec:1.5"
> > >
> > > // Transitive will bring in the unwanted string template library
> as
> > > well
> > > - compile "org.antlr:antlr-runtime:3.5.2", {
> > > + compile "org.antlr:antlr-runtime:3.3", {
> > > exclude group: "org.antlr", module: "stringtemplate"
> > > }
> > >
> > > // Antlr3 tool path used with the antlr3 task
> > > - antlr3 "org.antlr:antlr:3.5.2"
> > > + antlr3 "org.antlr:antlr:3.3"
> > >
> > > testRuntime "org.hsqldb:hsqldb:1.8.0.10"
> > > }
> > >
> > >
> >
> >
> > --
> > Howard M. Lewis Ship
> >
> > Creator of Apache Tapestry
> >
> > The source for Tapestry training, mentoring and support. Contact me to
> > learn how I can get you up and productive in Tapestry fast!
> >
> > (971) 678-5210
> > http://howardlewisship.com
> > @hlship
> >
>
--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com
@hlship
Re: git commit: Revert "update ANTLR to 3.5.2, fixes issues when
building the grammar with Java 8" Less4j is not compatible with ANTLR 3.5
Posted by Jochen Kemnade <ke...@gmail.com>.
Yes, i had also run the tests. It has to do with the version overrides, see
my other mails from earlier today.
Am 18.07.2014 17:47 schrieb "Howard Lewis Ship" <hl...@gmail.com>:
> This is very surprising, as I ran the full test suite with this change in
> place, and the Less4J related code in tapestry-webresources worked
> properly. What are the symptoms?
>
>
> On Fri, Jul 18, 2014 at 12:37 AM, <jk...@apache.org> wrote:
>
> > Repository: tapestry-5
> > Updated Branches:
> > refs/heads/master 2667b5a9d -> 4bd6302e0
> >
> >
> > Revert "update ANTLR to 3.5.2, fixes issues when building the grammar
> with
> > Java 8"
> > Less4j is not compatible with ANTLR 3.5
> >
> > This reverts commit 7702038519af9a548de52b757446b02212f7165f.
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
> > Commit:
> http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/4bd6302e
> > Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/4bd6302e
> > Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/4bd6302e
> >
> > Branch: refs/heads/master
> > Commit: 4bd6302e0eca754b86e0cb2a9a0ab1ec6270857c
> > Parents: 2667b5a
> > Author: Jochen Kemnade <jo...@eddyson.de>
> > Authored: Fri Jul 18 09:36:22 2014 +0200
> > Committer: Jochen Kemnade <jo...@eddyson.de>
> > Committed: Fri Jul 18 09:36:32 2014 +0200
> >
> > ----------------------------------------------------------------------
> > tapestry-core/build.gradle | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4bd6302e/tapestry-core/build.gradle
> > ----------------------------------------------------------------------
> > diff --git a/tapestry-core/build.gradle b/tapestry-core/build.gradle
> > index c16cd48..41c2adf 100644
> > --- a/tapestry-core/build.gradle
> > +++ b/tapestry-core/build.gradle
> > @@ -27,12 +27,12 @@ dependencies {
> > compile "commons-codec:commons-codec:1.5"
> >
> > // Transitive will bring in the unwanted string template library as
> > well
> > - compile "org.antlr:antlr-runtime:3.5.2", {
> > + compile "org.antlr:antlr-runtime:3.3", {
> > exclude group: "org.antlr", module: "stringtemplate"
> > }
> >
> > // Antlr3 tool path used with the antlr3 task
> > - antlr3 "org.antlr:antlr:3.5.2"
> > + antlr3 "org.antlr:antlr:3.3"
> >
> > testRuntime "org.hsqldb:hsqldb:1.8.0.10"
> > }
> >
> >
>
>
> --
> Howard M. Lewis Ship
>
> Creator of Apache Tapestry
>
> The source for Tapestry training, mentoring and support. Contact me to
> learn how I can get you up and productive in Tapestry fast!
>
> (971) 678-5210
> http://howardlewisship.com
> @hlship
>
Re: git commit: Revert "update ANTLR to 3.5.2, fixes issues when
building the grammar with Java 8" Less4j is not compatible with ANTLR 3.5
Posted by Howard Lewis Ship <hl...@gmail.com>.
This is very surprising, as I ran the full test suite with this change in
place, and the Less4J related code in tapestry-webresources worked
properly. What are the symptoms?
On Fri, Jul 18, 2014 at 12:37 AM, <jk...@apache.org> wrote:
> Repository: tapestry-5
> Updated Branches:
> refs/heads/master 2667b5a9d -> 4bd6302e0
>
>
> Revert "update ANTLR to 3.5.2, fixes issues when building the grammar with
> Java 8"
> Less4j is not compatible with ANTLR 3.5
>
> This reverts commit 7702038519af9a548de52b757446b02212f7165f.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
> Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/4bd6302e
> Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/4bd6302e
> Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/4bd6302e
>
> Branch: refs/heads/master
> Commit: 4bd6302e0eca754b86e0cb2a9a0ab1ec6270857c
> Parents: 2667b5a
> Author: Jochen Kemnade <jo...@eddyson.de>
> Authored: Fri Jul 18 09:36:22 2014 +0200
> Committer: Jochen Kemnade <jo...@eddyson.de>
> Committed: Fri Jul 18 09:36:32 2014 +0200
>
> ----------------------------------------------------------------------
> tapestry-core/build.gradle | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4bd6302e/tapestry-core/build.gradle
> ----------------------------------------------------------------------
> diff --git a/tapestry-core/build.gradle b/tapestry-core/build.gradle
> index c16cd48..41c2adf 100644
> --- a/tapestry-core/build.gradle
> +++ b/tapestry-core/build.gradle
> @@ -27,12 +27,12 @@ dependencies {
> compile "commons-codec:commons-codec:1.5"
>
> // Transitive will bring in the unwanted string template library as
> well
> - compile "org.antlr:antlr-runtime:3.5.2", {
> + compile "org.antlr:antlr-runtime:3.3", {
> exclude group: "org.antlr", module: "stringtemplate"
> }
>
> // Antlr3 tool path used with the antlr3 task
> - antlr3 "org.antlr:antlr:3.5.2"
> + antlr3 "org.antlr:antlr:3.3"
>
> testRuntime "org.hsqldb:hsqldb:1.8.0.10"
> }
>
>
--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com
@hlship