You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2023/01/04 17:42:21 UTC
[GitHub] [incubator-pekko] seglo commented on a diff in pull request #71: Rename sbt akka modules
seglo commented on code in PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#discussion_r1061680803
##########
LICENSE:
##########
@@ -207,6 +207,6 @@ Licenses for dependency projects can be found here:
---------------
-akka-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
+pekko-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
Review Comment:
I think it makes sense to use the artifact id here, but I noticed in `CONTRIBUTING` everything is referred to using the path/project name. I think in docs it would be better to reference by artifact name.
##########
LICENSE:
##########
@@ -207,6 +207,6 @@ Licenses for dependency projects can be found here:
---------------
-akka-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
+pekko-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
moved into the source package `akka.protobuf` so as to avoid version conflicts.
Review Comment:
```suggestion
moved into the source package `org.apache.pekko.protobuf` so as to avoid version conflicts.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org