You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/07/02 11:04:43 UTC

[GitHub] [maven-install-plugin] slawekjaranowski commented on a diff in pull request #15: [MINSTALL-115] Install At End feature (no extension)

slawekjaranowski commented on code in PR #15:
URL: https://github.com/apache/maven-install-plugin/pull/15#discussion_r912351058


##########
src/main/java/org/apache/maven/plugins/install/InstallMojo.java:
##########
@@ -88,56 +77,88 @@
     @Component
     private ProjectInstaller installer;
 
+    private enum State
+    {
+        SKIPPED, INSTALLED, TO_BE_INSTALLED
+    }
+
+    private static final String INSTALL_PROCESSED_MARKER = InstallMojo.class.getName() + ".processed";
+
+    private void putState( State state )
+    {
+        getPluginContext().put( INSTALL_PROCESSED_MARKER, state.name() );

Review Comment:
   here `getPluginContext()` and in other lines, eg in `getState` method - `session.getPluginContext(...)` - why different method is used for state?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org