[jira] [Commented] (WHIRR-288) Add blob store persistence for cluster state

["Tom White (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WHIRR-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029119#comment-13029119 ] 

Tom White commented on WHIRR-288:
---------------------------------

+1 Looks great.

A few comments, which we might address in follow-on issues.
* Have you thought about using Avro/JSON as the serialization format? It would then be easier to evolve.
* Have a parser object that has public methods that are easier to test than the ones on ClusterStateStore. They don't really belong there as the ClusterStateStore could use any representation it chooses.
* Rather than use NoopClusterStateStore, the default might be in-memory (which you implemented elsewhere)?

> Add blob store persistence for cluster state
> --------------------------------------------
>
>                 Key: WHIRR-288
>                 URL: https://issues.apache.org/jira/browse/WHIRR-288
>             Project: Whirr
>          Issue Type: Improvement
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.5.0
>
>         Attachments: WHIRR-288.patch, WHIRR-288.patch
>
>
> Right now Whirr persists the current cluster state (instance IDs, public and private IPs and roles) on the local filesystem (~/.whirr/<cluster-name>/instances). It should be possible to save the state as a blob so that it's easily accessible from multiple machines. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira