You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/01/06 16:30:28 UTC

[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1690: Check whether launchEngineOpHandle is null for KyuubiConnection:: getExecLog

turboFei commented on a change in pull request #1690:
URL: https://github.com/apache/incubator-kyuubi/pull/1690#discussion_r779677849



##########
File path: kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java
##########
@@ -237,6 +237,11 @@ public boolean hasMoreLogs() {
       throw new ClosedOrCancelledException(
           "Method getEngineLog() failed. The " + "connection has been closed.");
     }
+
+    if (launchEngineOpHandle == null) {

Review comment:
       I see,
   
   it was invoked in
   ```
     private void showRemainingLogsIfAny(Object sqlObject) {
       if (sqlObject instanceof KyuubiLoggable) {
         KyuubiLoggable kyuubiLoggable = (KyuubiLoggable) sqlObject;
         List<String> logs = null;
         do {
           try {
             logs = kyuubiLoggable.getExecLog();
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org