You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "kang-hl (via GitHub)" <gi...@apache.org> on 2023/05/08 09:47:26 UTC

[GitHub] [tomcat] kang-hl opened a new pull request, #614: Remove unnecessary reset

kang-hl opened a new pull request, #614:
URL: https://github.com/apache/tomcat/pull/614

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] kang-hl commented on pull request #614: Remove unnecessary reset

Posted by "kang-hl (via GitHub)" <gi...@apache.org>.
kang-hl commented on PR #614:
URL: https://github.com/apache/tomcat/pull/614#issuecomment-1543272195

   NioSocketWrapper is referenced by NioChannel, and it may need to release the reference.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] markt-asf closed pull request #614: Remove unnecessary reset

Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf closed pull request #614: Remove unnecessary reset
URL: https://github.com/apache/tomcat/pull/614


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] kang-hl commented on pull request #614: Remove unnecessary reset

Posted by "kang-hl (via GitHub)" <gi...@apache.org>.
kang-hl commented on PR #614:
URL: https://github.com/apache/tomcat/pull/614#issuecomment-1543285158

   > The method is necessary. It releases the reference to the SocketWrapper, allowing it ti be GC'd.
   
   NioSocketWrapper is referenced by NioChannel, and it may need to release the reference.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] markt-asf commented on pull request #614: Remove unnecessary reset

Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #614:
URL: https://github.com/apache/tomcat/pull/614#issuecomment-1542634643

   The method is necessary. It releases the reference to the SocketWrapper, allowing it ti be GC'd.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org