[GitHub] [geode-native] albertogpz commented on issue #556: GEODE-7509: Fix memory leaks in C++ client

["albertogpz (GitHub)" <gi...@apache.org>]

I forgot to ask something that did not really feel right on one of the fixes.
I noticed I had to add a `delete this` sentence in the `handle_close()` method of the different ExpiryHandler classes in order to remove the leaking of the memory of the handlers in spite the fact there was a comment stating that the handler would be deleted now in `GF_Timer_Heap_ImmediateReset_T`. It seems that the handler was not deleted by that class in all cases.
Apart from that, the `TombstoneExpiryHandler.handle_close()` method did not require such delete sentence because these handlers were deleted in `TombstoneList::cleanUp()`.
If you have a suggestion to make this code clear I would be willing to improve it.

[ Full content available at: https://github.com/apache/geode-native/pull/556 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org