You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/12/11 01:53:05 UTC

[GitHub] [incubator-gobblin] autumnust commented on issue #2846: [GOBBLIN-1001] Implement TimePartitionGlobFinder

autumnust commented on issue #2846: [GOBBLIN-1001] Implement TimePartitionGlobFinder
URL: https://github.com/apache/incubator-gobblin/pull/2846#issuecomment-564341258
 
 
   > @autumnust It does use, compositely use instead of inheriting, an existing GlobFinder, which is `DefaultFileSystemGlobFinder`.
   
   OK Gotcha. If `enableEmptyPartition` is not enabled, it does nothing more than just setting a different pattern using `DefaultFileSystemGlobFinder`. If it does, it somehow creates empty dataset for yesterday's partitions. This doesn't seem to be a generic finder to me but serving a very specific purpose. Would you consider doing it as a separated extension for GlobFinder internally instead of open-source?  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services