[GitHub] nickva opened a new pull request #676: Fix replication Javascript test

[gi...@git.apache.org]

nickva opened a new pull request #676: Fix replication Javascript test
URL: https://github.com/apache/couchdb/pull/676
 
 
   The test was flaky for a variety of reasons:
   
    * waitForSeq only waited for 3 seconds and on failure it never explitly
      indicated an error and just waited for the comparison below to fail. So made
      it wait for 30 seconds and also throw an exception right away if it fails.
   
    * Last waitForSeq was used after task was canceled. So it just wasted time
      waiting until timeout as the task was null. So created a function to
      wait for task to be null.
   
    * waitForSeq spun in a tight do/while loop querying _active_tasks. In some test
      environment with minimal CPU resources that's not the greatest thing to do.
      So made it wait for 0.5 seconds between retries.
   
    * waitForSeq waited for replication task's through_seq value to match source
      update sequence from source db info. Those don't necessarily match. Instead
      made waitForSeq use the changes feed last sequence since that's what the
      replication task uses to update through_seq.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services